This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Remove try/catch block on @Background/@UIThread methods#682
Merged
DayS merged 2 commits intoandroidannotations:developfrom Jul 28, 2013
Merged
Remove try/catch block on @Background/@UIThread methods#682DayS merged 2 commits intoandroidannotations:developfrom
DayS merged 2 commits intoandroidannotations:developfrom
Conversation
Because the exception is now propagated, there is no need of catching it.
Contributor
|
As catching an exception is not in the AA philosophy, I think you should remove it |
Contributor
Author
|
done 4a6a77b |
DayS
added a commit
that referenced
this pull request
Jul 28, 2013
Remove try/catch block on @Background/@UIThread methods
Contributor
|
Great 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #646 and add fix for PR #677
Because the exception is now propagated, there is no need of catching
it.
Generated code :
Notes
surroundWithTryCatchmethod is now unused, don't know if I have to remove it or not.