This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Upgrade to RoboGuice 2#983
Merged
DayS merged 3 commits intoandroidannotations:developfrom May 31, 2014
Merged
Conversation
This commit adds RoboGuice 2 support, RoboGuice 1 support is dropped.
WonderCsabo
added a commit
to WonderCsabo/androidannotations
that referenced
this pull request
May 2, 2014
Initial implementation for upgrading to Robolectric 2.2. SaveInstanceStateActivityParameterizedTest is failing, which is due to a Robolectric bug described in androidannotations#973. This commit dependes on RoboGuice 2 which is implemented in androidannotations#983. All other tests should be OK. This involves lots of code change and simplification thanks to Robolectric 2.2.
WonderCsabo
added a commit
to WonderCsabo/androidannotations
that referenced
this pull request
May 2, 2014
Initial implementation for upgrading to Robolectric 2.2. SaveInstanceStateActivityParameterizedTest is failing, which is due to a Robolectric bug described in androidannotations#973. This commit dependes on RoboGuice 2 which is implemented in androidannotations#983. All other tests should be OK. This involves lots of code change and simplification thanks to Robolectric 2.2.
Contributor
|
Unit test doesn't seems to work with this PR. |
Member
Author
|
The unit tests for this are implemented in #984, as i noted before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #172.
No tests for now, those will be in a separate commit as noted in #973.