Merged
Conversation
42397fa to
b20050f
Compare
Contributor
Author
|
@eladkal @o-nikolas @josh-fell this is a follow up of my previous PR #28950 where I intended to submit 3 separate PRs for each sensor. I have addressed comments in the older PR and created this PR for just the partition sensor (previously merged the SQL sensor via #30477). |
janvandervegt-db
left a comment
There was a problem hiding this comment.
Some small pieces of feedback but looks good!
c546ba7 to
675c3bc
Compare
janvandervegt-db
approved these changes
May 3, 2023
10e68e3 to
50b8ab3
Compare
31b375f to
b552c02
Compare
b552c02 to
1b80ce1
Compare
potiuk
approved these changes
May 13, 2023
80 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for Databricks Partition Sensor.
Note: Previous comments via PR #28950 have been addressed.