Skip to content

Comments

Bump jsonschema version to 4.18.0#32445

Merged
potiuk merged 2 commits intoapache:mainfrom
hussein-awala:bump_jsonschema
Jul 10, 2023
Merged

Bump jsonschema version to 4.18.0#32445
potiuk merged 2 commits intoapache:mainfrom
hussein-awala:bump_jsonschema

Conversation

@hussein-awala
Copy link
Member

@hussein-awala hussein-awala commented Jul 8, 2023

related: #32434

Bump the min jsonschema version to 4.18.0 to improve its performance (more details)

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal eladkal added this to the Airflow 2.6.4 milestone Jul 8, 2023
@hussein-awala
Copy link
Member Author

hussein-awala commented Jul 8, 2023

python-openapi/openapi-schema-validator@5bf8b10

I will try to bump openapi-schema-validator version in amazon provider

@hussein-awala
Copy link
Member Author

hussein-awala commented Jul 8, 2023

and there is a core test which fail with python 3.11:

FAILED tests/models/test_param.py::TestParam::test_string_date_format[20120503] - airflow.exceptions.ParamValidationError: '20120503' is not a 'date'

Failed validating 'format' in schema:
    {'format': 'date', 'type': 'string'}

On instance:
    '20120503'

@tirkarthi
Copy link
Contributor

tirkarthi commented Jul 8, 2023

python-jsonschema/jsonschema#1056

@hussein-awala hussein-awala requested a review from o-nikolas as a code owner July 9, 2023 09:47
tirkarthi
tirkarthi reviewed Jul 9, 2023
View reviewed changes
tests/providers/amazon/aws/hooks/test_cloud_formation.py Outdated
Copy link
Contributor

@tirkarthi tirkarthi Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is using pytest.mark.skip a better option here?

@potiuk
Copy link
Member

potiuk commented Jul 9, 2023

needs tests fixing :(

@hussein-awala hussein-awala mentioned this pull request Jul 10, 2023
Merged
@hussein-awala @potiuk
Bump jsonschema version
d8b000a 
Signed-off-by: Hussein Awala <hussein@awala.fr>
@hussein-awala @potiuk
stop using moto cloud_formation mock
d05a4af 
Signed-off-by: Hussein Awala <hussein@awala.fr>
@potiuk potiuk force-pushed the bump_jsonschema branch from b3edcd2 to d05a4af Compare July 10, 2023 13:00
@potiuk
Copy link
Member

potiuk commented Jul 10, 2023

Merging. 3.11 and other tests passed with it, and main is already broken so better to merge it fast to fix it.

@potiuk potiuk merged commit 48edb2b into apache:main Jul 10, 2023
@eladkal eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@potiuk potiuk potiuk approved these changes

@eladkal eladkal eladkal approved these changes

@o-nikolas o-nikolas Awaiting requested review from o-nikolas

Assignees

No one assigned

Labels

type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Milestone

Airflow 2.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@hussein-awala @tirkarthi @potiuk @eladkal @ephraimbuddy