Revert the Python 3.11 exclusion for date isoformat#32490
Merged
potiuk merged 1 commit intoapache:mainfrom Jul 10, 2023
Merged
Conversation
amoghrajesh
approved these changes
Jul 10, 2023
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Good find. Looks good to me +1
hussein-awala
approved these changes
Jul 10, 2023
Member
hussein-awala
left a comment
There was a problem hiding this comment.
will conflict with #32445, I will rebase once this one is merged
The official Python image for 3.11 had a brief period when the date `20120503` has been an acceptable date, but it is not accepted as of 3.11.4 release on 5th of July. This PR reverts the changes in tests implemented in apache#27264 to accomodate for it and brings back the date as error case.
77b640e to
cb8f643
Compare
Member
Author
|
I am totally puzzled by this one BTW. I have no idea why the test worked with the previous base images :) |
Member
|
This is related to jsonschema validation, this will be fixed once we bump its version |
Member
Author
|
Ah OK. Understood. Merging and yours right after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official Python image for 3.11 had a brief period when the date
20120503has been an acceptable date, but it is not accepted as of 3.11.4 release on 5th of July.This PR reverts the changes in tests implemented in #27264 to accomodate for it and brings back the date as error case.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.