Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.16%. Comparing base (3afab9a) to head (afb263d).
Report is 27 commits behind head on 4.19.

@@             Coverage Diff              @@
##               4.19   #10629      +/-   ##
============================================
- Coverage     15.16%   15.16%   -0.01%     
+ Complexity    11328    11326       -2     
============================================
  Files          5414     5414              
  Lines        474814   474816       +2     
  Branches      57911    57912       +1     
============================================
- Hits          72026    72021       -5     
- Misses       394734   394740       +6     
- Partials       8054     8055       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

in my opinion, if we consider it as a bug, the bug exists in almost all input area on UI

we'd better trim all input area, not only this one.

I agree @weizhouapache but it would still be a case by case solution in a lot of cases (including this one) as the condition is for it to be done is conspicuous. Also I doubt this is always desirable like in description fields and other non-numerical fields. Alternatively we might opt for a solution in the API that handles numerical fields automatically.

I agree @weizhouapache but it would still be a case by case solution in a lot of cases (including this one) as the condition is for it to be done is conspicuous. Also I doubt this is always desirable like in description fields and other non-numerical fields. Alternatively we might opt for a solution in the API that handles numerical fields automatically.

@DaanHoogland
I like your idea to hand/trim the input in API server

ps: if vm name has trailing spaces, deployment fails

ps2: if volume is created with name "asd ", searching volumes by name "asd" will return empty result.