Skip to content

UI: show checksum field when register or upload template/isos#10725

Merged
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-ui-register-template-iso-checksum
May 1, 2025
Merged

UI: show checksum field when register or upload template/isos#10725
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-ui-register-template-iso-checksum

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Apr 15, 2025

Description

This PR fixes #9843

note: check on allowed has been removed in #10193

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache linked an issue Apr 15, 2025 that may be closed by this pull request
Provide a Checksum box for Template/ISO registration #9843
Closed
@weizhouapache weizhouapache marked this pull request as ready for review April 15, 2025 12:41
@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (f13cf59) to head (1f68af3).
Report is 18 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10725   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
- Complexity    11332    11337    +5     
=========================================
  Files          5415     5415           
  Lines        474893   474893           
  Branches      57920    57920           
=========================================
+ Hits          72046    72058   +12     
+ Misses       394792   394775   -17     
- Partials       8055     8060    +5
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but one question: what would be the significance of allowed?

@weizhouapache
Copy link
Member Author

weizhouapache commented Apr 15, 2025

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Apr 15, 2025

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 15, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10725 (QA-JID-599)

@yadvr yadvr added this to the 4.19.3 milestone Apr 17, 2025
@weizhouapache
Copy link
Member Author

weizhouapache commented Apr 24, 2025

looks good, but one question: what would be the significance of allowed?

have you checked #10193 ? @DaanHoogland

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Apr 24, 2025

looks good, but one question: what would be the significance of allowed?

have you checked #10193 ? @DaanHoogland

yes, allowed stays in but is removed from the condition. Isn’t the significance now just isRootAdmin? (genuine question!)

@weizhouapache
Copy link
Member Author

weizhouapache commented Apr 24, 2025

looks good, but one question: what would be the significance of allowed?

have you checked #10193 ? @DaanHoogland

yes, allowed stays in but is removed from the condition. Isn’t the significance now just isRootAdmin? (genuine question!)

some fields (xenserver tools version) are only allowed for root admin.
this "direct download" is allowed for regular users, so allowed has been removed in #10193
the code could be optimized, which is not in the scope of this PR

@yadvr yadvr requested review from Pearl1594 and nvazquez May 1, 2025 05:55
@Pearl1594 Pearl1594 requested a review from DaanHoogland May 1, 2025 06:01
@Pearl1594
Copy link
Contributor

Pearl1594 commented May 1, 2025

code LGTM

DaanHoogland
DaanHoogland approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked in qa

@DaanHoogland DaanHoogland merged commit 4c072b5 into apache:4.19 May 1, 2025
25 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-ui-register-template-iso-checksum branch May 1, 2025 07:17
@DaanHoogland DaanHoogland mentioned this pull request May 1, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
UI: show checksum field when register or upload template/isos (apache…
198d624 
…#10725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

Provide a Checksum box for Template/ISO registration

5 participants

@weizhouapache @blueorangutan @DaanHoogland @Pearl1594 @yadvr