Skip to content

cloudutils: use "ip route" command instead of "route -n" in networkConfig.py#10726

Merged
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-networkConfig-ip-route
May 1, 2025
Merged

cloudutils: use "ip route" command instead of "route -n" in networkConfig.py#10726
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-networkConfig-ip-route

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Apr 15, 2025 •
edited
Loading

Description

This PR uses 'ip route' command instead of 'route -n' command in networkConfig.py

route is provided by legacy net-tools package which is not installed by default in some distributions
ip is provided by iproute2 package which is a dependency of cloudstack-agent package

the two commands have the same result

# route -n|awk '/^0.0.0.0/ {print $2,$8}'
10.0.32.1 cloudbr0

# ip route show default | awk '{print $3,$5}'
10.0.32.1 cloudbr0

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added the Python Warning... Python code Ahead! label Apr 15, 2025
@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (f13cf59) to head (58a723a).
Report is 16 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10726      +/-   ##
============================================
- Coverage     15.17%   15.17%   -0.01%     
  Complexity    11332    11332              
============================================
  Files          5415     5415              
  Lines        474893   474893              
  Branches      57920    57920              
============================================
- Hits          72046    72042       -4     
- Misses       394792   394796       +4     
  Partials       8055     8055
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache marked this pull request as ready for review April 15, 2025 13:26
@weizhouapache
Copy link
Member Author

weizhouapache commented Apr 15, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 15, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland
DaanHoogland approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

blueorangutan commented Apr 15, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13062

@weizhouapache weizhouapache changed the title cloudutils: use ip command instead of route in networkConfig.py cloudutils: use "ip route" command instead of "route -n" in networkConfig.py Apr 15, 2025
@yadvr yadvr added this to the 4.19.3 milestone Apr 17, 2025
@yadvr
Copy link
Member

yadvr commented Apr 17, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 17, 2025

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Apr 18, 2025

[SF] Trillian test result (tid-13035)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49494 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10726-t13035-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_secured_to_nonsecured_vm_migration Error 397.84 test_vm_life_cycle.py

@yadvr yadvr merged commit 7f16a20 into apache:4.19 May 1, 2025
25 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-networkConfig-ip-route branch May 1, 2025 06:10
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
cloudutils: use ip command instead of route in networkConfig.py (apac…
09c98d5 
…he#10726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache @blueorangutan @yadvr @DaanHoogland