Skip to content

Don't specify ipv6 ranges for shared network#10746

Merged
weizhouapache merged 3 commits intoapache:4.19from
shapeblue:ghi10664-specifySharedVlan
Apr 24, 2025
Merged

Don't specify ipv6 ranges for shared network#10746
weizhouapache merged 3 commits intoapache:4.19from
shapeblue:ghi10664-specifySharedVlan

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Apr 17, 2025

Description

This PR... addresses the comments at https://github.com/apache/cloudstack/pull/10704/files#r2048392976

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Apr 17, 2025

@blueorangutan package

@codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (7b68615) to head (db06bb7).
Report is 8 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ain/java/com/cloud/network/NetworkServiceImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10746   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
- Complexity    11333    11334    +1     
=========================================
  Files          5415     5415           
  Lines        474911   474912    +1     
  Branches      57926    57926           
=========================================
+ Hits          72050    72051    +1     
+ Misses       394806   394804    -2     
- Partials       8055     8057    +2
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache
weizhouapache approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland
can you remove the comment ?

alternatively, we can add a INFO message instead of throwing an exception

DaanHoogland
DaanHoogland commented Apr 17, 2025
View reviewed changes
@DaanHoogland DaanHoogland mentioned this pull request Apr 18, 2025
Merged
14 tasks
@Pearl1594 Pearl1594 added this to the 4.19.3 milestone Apr 21, 2025
@weizhouapache
Copy link
Contributor

weizhouapache commented Apr 22, 2025

@blueorangutan package

weizhouapache
weizhouapache reviewed Apr 22, 2025
View reviewed changes
@DaanHoogland DaanHoogland marked this pull request as ready for review April 23, 2025 10:43
@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Apr 23, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 23, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 23, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13147

@weizhouapache
Copy link
Contributor

weizhouapache commented Apr 23, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 23, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Apr 24, 2025

[SF] Trillian test result (tid-13107)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50216 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10746-t13107-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 136.83 test_vm_life_cycle.py
test_01_secure_vm_migration Error 136.83 test_vm_life_cycle.py

@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Apr 24, 2025

It seems one of the hosts is left in an undesired state by a prior test and so test_01_secure_vm_migration fails.
This will surely be an issue over most test runs (and might be internitted :( )

  File "/usr/local/lib/python3.6/site-packages/marvin/jsonHelper.py", line 155, in getResultObj
    raise cloudstackException.CloudstackAPIException(respname, errMsg)
marvin.cloudstackException.CloudstackAPIException: Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Unable to deploy the VM as the host: pr10746-t13107-kvm-ol8-kvm1 is not in the right state

[SF] Trillian test result (tid-13107) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 50216 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10746-t13107-kvm-ol8.zip Smoke tests completed. 132 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 136.83 test_vm_life_cycle.py
test_01_secure_vm_migration Error 136.83 test_vm_life_cycle.py

@weizhouapache @Pearl1594 , I think we can call this success.

@weizhouapache
Copy link
Contributor

weizhouapache commented Apr 24, 2025

@weizhouapache @Pearl1594 , I think we can call this success.

agree. let's merge ?

@weizhouapache weizhouapache merged commit 422264f into apache:4.19 Apr 24, 2025
23 of 26 checks passed
@DaanHoogland DaanHoogland deleted the ghi10664-specifySharedVlan branch April 24, 2025 08:28
@blueorangutan
Copy link

blueorangutan commented Apr 24, 2025

[SF] Trillian test result (tid-13122)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52439 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10746-t13122-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_migrate_vm Error 51.61 test_vm_life_cycle.py

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@DaanHoogland @weizhouapache @dhslove
server: Don't specify ipv6 ranges for shared network (apache#10746)
7de926b 
* assume SLAAC takes care

* log info

* Update server/src/main/java/com/cloud/network/NetworkServiceImpl.java

---------

Co-authored-by: Wei Zhou <weizhou@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weizhouapache weizhouapache weizhouapache approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@wido wido Awaiting requested review from wido

Assignees

No one assigned

Labels

component:networking

Projects

None yet

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

4 participants

@DaanHoogland @weizhouapache @blueorangutan @Pearl1594