Skip to content

.github: fix simulator CI caused by imcompatibility between python3.10 and nosetests#10753

Merged
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-ci
Apr 18, 2025
Merged

.github: fix simulator CI caused by imcompatibility between python3.10 and nosetests#10753
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-ci

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Apr 18, 2025

Description

This PR fixes the issue with simulator CI

==== Marvin Init Successful ====
    elif isfunction(test) and self.selector.wantFunction(test):
  File "/home/runner/.local/lib/python3.10/site-packages/nose/selector.py", line 149, in wantFunction
    plug_wants = self.plugins.wantFunction(function)
  File "/home/runner/.local/lib/python3.10/site-packages/nose/plugins/manager.py", line 99, in __call__
    return self.call(*arg, **kw)
  File "/home/runner/.local/lib/python3.10/site-packages/nose/plugins/manager.py", line [167](https://github.com/apache/cloudstack/actions/runs/14532936308/job/40775972427#step:14:168), in simple
    result = meth(*arg, **kw)
  File "/home/runner/.local/lib/python3.10/site-packages/nose/plugins/attrib.py", line 278, in wantFunction
    return self.validateAttrib(function)
  File "/home/runner/.local/lib/python3.10/site-packages/nose/plugins/attrib.py", line 242, in validateAttrib
    if isinstance(value, collections.Callable):
AttributeError: module 'collections' has no attribute 'Callable'

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (8c9216d) to head (9c13c47).
Report is 3 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10753   +/-   ##
=========================================
  Coverage     15.16%   15.17%           
- Complexity    11333    11337    +4     
=========================================
  Files          5415     5415           
  Lines        474916   474912    -4     
  Branches      57926    57926           
=========================================
+ Hits          72043    72061   +18     
+ Misses       394817   394793   -24     
- Partials       8056     8058    +2
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache marked this pull request as ready for review April 18, 2025 10:20
DaanHoogland
DaanHoogland approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Apr 18, 2025

ci only, failures will have to be dealt with later

@DaanHoogland DaanHoogland merged commit f055268 into apache:4.19 Apr 18, 2025
23 of 25 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-fix-ci branch April 18, 2025 11:27
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
.github: fix simulator CI caused by imcompatibility between python3.1…
3e516c6 
…0 and nosetests (apache#10753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weizhouapache @DaanHoogland