CLOUDSTACK-8612 [VMware] Make vCenter session timeout configurable for volume snapshot#2099
Closed
sureshanaparti wants to merge 1 commit intomasterfrom
unknown repository
Closed
CLOUDSTACK-8612 [VMware] Make vCenter session timeout configurable for volume snapshot#2099sureshanaparti wants to merge 1 commit intomasterfrom unknown repository
sureshanaparti wants to merge 1 commit intomasterfrom
unknown repository
Conversation
Closed
Contributor
Author
|
@borisstoyanov Can you please run vmware tests on this PR. |
Contributor
Author
|
@sateesh-chodapuneedi @rhtyd Please review the code changes |
…r volume snapshot
Member
|
@sureshanaparti Can you please resolve the conflicts and rebase? |
Member
|
@sureshanaparti looks like good feature, can you rebase, fix conflicts, move schema change to 4.10->4.11 path? |
Contributor
|
ping @rhtyd do you know if this is still an issue? |
Contributor
|
ping all. I will close this one if no activity before 4.15 |
Member
|
Hi, the PR got auto-closed due to no known source repository or some other Github-specific issue during the recent renaming of the default branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
[VMware] Make vCenter session timeout configurable for volume snapshot
Split the existing vCenter session timeout configuration into two configurations to ensure that a high timeout value set for snapshot backup operation and will not affect vCenter connections made for any other operations besides volume snapshot.
To tune timeout value for CS's session vCenter during snapshot backup operation
'vmware.snapshot.backup.session.timeout' (new; default: 20 minutes)
For all other operations - 'vmware.vcenter.session.timeout' (existing; default: 20 minutes)
There is a timeout for async-jobs that ensures that any job that has been in process for too long is cancelled. This timeout is configurable using a global configuration ‘job.cancel.threshold.minutes’ and it defaults to 1 hour. For large volumes, even though users configure other snapshot timeout values (‘vmware.snapshot.backup.session.timeout’ and ‘backup.snapshot.wait‘) to a very high value, the snapshot operation will still fail because the job will be cancelled in 1 hour.
A new configuration parameter 'volume.snapshot.job.cancel.threshold' has been introduced that will allow admins to separate out the job cancellation timeout for ‘volume snapshot’ jobs from other vm work jobs.
This closes #562