KVM: Enhancements for direct download feature by nvazquez · Pull Request #3374 · apache/cloudstack

nvazquez · 2019-06-05T02:58:41Z

Description

Extend improvements on PR #2995 and #3075

Add an API method to revoke certificates from hosts
Add a background task to sync missing certificates to hosts (which for some reason could not be uploaded before)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

nvazquez · 2019-06-05T02:59:20Z

@blueorangutan package

blueorangutan · 2019-06-05T02:59:51Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-05T03:20:21Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2844

nvazquez · 2019-06-06T23:45:05Z

@blueorangutan test

yadvr · 2019-06-07T06:15:29Z

@nvazquez can you fix the conflicts?

nvazquez · 2019-06-10T12:23:43Z

@blueorangutan package

blueorangutan · 2019-06-10T12:24:15Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-10T12:56:11Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2872

nvazquez · 2019-06-10T12:56:48Z

@blueorangutan test

blueorangutan · 2019-06-10T12:57:14Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-06-10T21:13:24Z

Trillian test result (tid-3678)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3374-t3678-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_direct_download.py
Smoke tests completed. 70 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_upload_direct_download_certificates	`Failure`	0.00	test_direct_download.py

nvazquez · 2019-06-11T14:29:25Z

@blueorangutan package

blueorangutan · 2019-06-11T14:30:20Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-11T14:51:12Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2883

nvazquez · 2019-06-11T23:18:00Z

@blueorangutan test

blueorangutan · 2019-06-11T23:18:21Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-06-12T09:06:07Z

Trillian test result (tid-3687)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3374-t3687-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 70 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_rvpc_multi_tiers	`Failure`	408.25	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	434.76	test_vpc_redundant.py

yadvr · 2019-06-20T09:47:04Z

Fixed merge conflict please check @nvazquez

nvazquez · 2019-06-25T03:45:55Z

Thanks @rhtyd
@blueorangutan package

blueorangutan · 2019-06-25T03:46:07Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-25T04:07:57Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-10

nvazquez · 2019-06-25T04:48:42Z

@blueorangutan test

blueorangutan · 2019-06-25T04:49:09Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

nvazquez · 2019-07-12T04:04:55Z

@borisstoyanov please find the latest fix for the issues we've been through
@blueorangutan package

blueorangutan · 2019-07-12T04:05:16Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-07-12T04:41:05Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-119

yadvr · 2019-07-12T07:09:12Z

@blueorangutan test

blueorangutan · 2019-07-12T07:10:18Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov

I'm having an issue with the background task, I've stopped one of the agents and uploaded cert, then started the agent. Certificate was not on the host, as expected, and I've just left it there running so that within and hour (I've set the global setting to 1) to upload the cert to host.
It's been 1.5 hours and I still don't see the cert on the host. I suppose there's something wrong with the background task.
cc: @nvazquez

blueorangutan · 2019-07-12T17:28:36Z

Trillian test result (tid-152)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35108 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3374-t152-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 70 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_cancel_host_maintenace_with_no_migration_jobs	`Failure`	0.16	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	2.55	test_host_maintenance.py
test_hostha_enable_ha_when_host_disabled	`Error`	1.67	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	302.87	test_hostha_kvm.py

nvazquez · 2019-07-12T18:10:21Z

@borisstoyanov fixed, please consider rebuilding your test environment as I have slightly modified the database schema

yadvr · 2019-07-15T11:30:16Z

@blueorangutan package

blueorangutan · 2019-07-15T11:30:32Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2019-07-15T11:36:06Z

Ping @borisstoyanov @PaulAngus

nvazquez · 2019-07-15T16:14:17Z

@rhtyd @PaulAngus @borisstoyanov please also check: apache/cloudstack-documentation#54

borisstoyanov

LGTM, confirmed both the API and background tasks are working as expected

nvazquez · 2019-07-17T15:18:11Z

Thanks @borisstoyanov
@blueorangutan package

blueorangutan · 2019-07-17T15:18:42Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-07-17T15:38:58Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-143

nvazquez · 2019-07-17T15:46:26Z

@blueorangutan test

blueorangutan · 2019-07-17T15:46:41Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-07-18T01:45:57Z

Trillian test result (tid-173)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34208 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3374-t173-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_hostha_enable_ha_when_host_in_maintenance	`Error`	303.82	test_hostha_kvm.py

nvazquez added this to the 4.13.0.0 milestone Jun 5, 2019

nvazquez added component:templates component:kvm labels Jun 5, 2019

nvazquez self-assigned this Jun 5, 2019

nvazquez closed this Jun 6, 2019

nvazquez reopened this Jun 6, 2019

nvazquez force-pushed the kvmddadditions branch from a99aa3a to ae65822 Compare June 10, 2019 12:19

borisstoyanov reviewed Jul 12, 2019

View reviewed changes

borisstoyanov approved these changes Jul 17, 2019

View reviewed changes

nvazquez closed this Jul 17, 2019

nvazquez reopened this Jul 17, 2019

nvazquez added 5 commits July 17, 2019 23:58

Add revoke certificates API

9ca0661

Add background task to sync certificates

de3923e

Fix marvin test and revoke certificate

126ed86

Fix certificate sent to hypervisor was missing headers

cd5f473

Fix background task for uploading certificates to hosts

7cf06ed

nvazquez force-pushed the kvmddadditions branch from 2779e3c to 7cf06ed Compare July 18, 2019 02:59

nvazquez merged commit a1a9fb8 into apache:master Jul 18, 2019

DaanHoogland mentioned this pull request Jan 3, 2020

Direct Download with IPv6 only fails #3047

Closed

nvazquez deleted the kvmddadditions branch April 6, 2020 14:41

Conversation

nvazquez commented Jun 5, 2019

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

nvazquez commented Jun 5, 2019

Uh oh!

blueorangutan commented Jun 5, 2019

Uh oh!

blueorangutan commented Jun 5, 2019

Uh oh!

nvazquez commented Jun 6, 2019

Uh oh!

yadvr commented Jun 7, 2019

Uh oh!

nvazquez commented Jun 10, 2019

Uh oh!

blueorangutan commented Jun 10, 2019

Uh oh!

blueorangutan commented Jun 10, 2019

Uh oh!

nvazquez commented Jun 10, 2019

Uh oh!

blueorangutan commented Jun 10, 2019

Uh oh!

blueorangutan commented Jun 10, 2019

Uh oh!

nvazquez commented Jun 11, 2019

Uh oh!

blueorangutan commented Jun 11, 2019

Uh oh!

blueorangutan commented Jun 11, 2019

Uh oh!

nvazquez commented Jun 11, 2019

Uh oh!

blueorangutan commented Jun 11, 2019

Uh oh!

blueorangutan commented Jun 12, 2019

Uh oh!

yadvr commented Jun 20, 2019

Uh oh!

nvazquez commented Jun 25, 2019

Uh oh!

blueorangutan commented Jun 25, 2019

Uh oh!

blueorangutan commented Jun 25, 2019

Uh oh!

nvazquez commented Jun 25, 2019

Uh oh!

blueorangutan commented Jun 25, 2019

Uh oh!

nvazquez commented Jul 12, 2019

Uh oh!

blueorangutan commented Jul 12, 2019

Uh oh!

blueorangutan commented Jul 12, 2019

Uh oh!

yadvr commented Jul 12, 2019

Uh oh!

blueorangutan commented Jul 12, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jul 12, 2019

Uh oh!

nvazquez commented Jul 12, 2019

Uh oh!

yadvr commented Jul 15, 2019

Uh oh!

blueorangutan commented Jul 15, 2019

Uh oh!

yadvr commented Jul 15, 2019

Uh oh!

nvazquez commented Jul 15, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment