master: travis and trillian smoketests fixes and stabilisation by yadvr · Pull Request #3476 · apache/cloudstack

yadvr · 2019-07-08T06:37:07Z

The aim of the PR is to stabilise master and fix failing smoketests both on Travis and Trillian.

Fix travis CI tests grouping to run in about 40 mins or less
Add more component tests and any new smoke tests

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

When resource type project is passed, users shoulnd't need to pass the projectid param, previous tests should pass (test_tags.py). Fixes apache#3377 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2019-07-08T09:43:24Z

List of consistenly failing tests:

 test_15_project_tag                     | Failure | 1.160   | test_tags  
+--------------------------------+---------+---------+-------------------------+
| test_04_deploy_multiple_vm_wit | Failure | 141.249 | test_cpu_domain_limits  |
| h_multiple_core

Intermittent failures:

| test_18_invalid_list_pa | marvin.cloudstackExcept | 0.052   | test_tags      |
| rameters                | ion.CloudstackAPIExcept |         |                |
|                         | ion                     |         |                |
| test_19_delete_add_same | exceptions.Exception    | 1.077   | test_tags      |
| _tag                    |                         |         |                |
+-------------------------+-------------------------+---------+----------------+
| test_20_create_tags_mul | exceptions.Exception    | 1.204   | test_tags      |
| tiple_resources         |                         |         |                |
+-------------------------+-------------------------+---------+----------------+
| test_21_create_tag_stop | Failure                 | 2.181   | test_tags      |
| ped_vm                  |                         |         |                |
+-------------------------+-------------------------+---------+----------------+
| test_22_create_tag_dest | exceptions.Exception    | 5.306   | test_tags      |
| royed_vm                |                         |         |         
+--------------------------------+---------+---------+-------------------------+
| test_04_deploy_multiple_vm_wit | Failure | 141.249 | test_cpu_domain_limits  |
| h_multiple_core

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

ustcweizhou · 2019-07-08T11:42:31Z

server/src/main/java/com/cloud/api/query/QueryManagerImpl.java

+                final ProjectVO project = _projectDao.findByUuidIncludingRemoved(resourceId);
+                if (project != null) {
+                    projectId = project.getId();
+                }


return empty if projectId is null ?

Yes, if projectid is not passed and invalid resourceid is passed.

so, if projectId is still null here, return empty result or continue on searching ?

This will continue to search and return empty result/response. This only happens when a user does not pass the projectId and invalid resourceid or does not pass the resourceid. I checked against 4.11 for behaviour and tried to fix in a way that user experience is same as 4.11.

sounds good to me.

yadvr · 2019-07-09T08:07:50Z

@blueorangutan package

blueorangutan · 2019-07-09T08:08:05Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-07-09T08:29:56Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-103

yadvr · 2019-07-09T09:30:15Z

@blueorangutan test matrix

blueorangutan · 2019-07-09T09:31:04Z

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2019-07-09T17:25:54Z

@blueorangutan test

blueorangutan · 2019-07-09T17:26:05Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-07-09T18:36:09Z

Trillian test result (tid-124)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31059 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3476-t124-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 71 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	`Failure`	17.62	test_scale_vm.py

blueorangutan · 2019-07-10T01:19:56Z

Trillian test result (tid-133)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26757 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3476-t133-kvm-centos7.zip
Smoke tests completed. 72 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

yadvr · 2019-07-10T06:26:51Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-07-10T06:27:07Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

blueorangutan · 2019-07-11T09:58:07Z

Trillian test result (tid-140)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36014 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3476-t140-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 68 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_reboot_router	`Error`	312.75	test_network.py
test_08_start_router	`Error`	68.75	test_routers.py
test_09_reboot_router	`Error`	1.10	test_routers.py
test_02_list_snapshots_with_removed_data_store	`Error`	0.21	test_snapshots.py
test_01_volume_usage	`Error`	10.45	test_usage.py

yadvr · 2019-07-11T09:59:04Z

@blueorangutan package

blueorangutan · 2019-07-11T10:00:13Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-07-11T10:24:16Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-116

yadvr · 2019-07-11T10:33:53Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-07-11T10:34:13Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

blueorangutan · 2019-07-11T21:01:37Z

Trillian test result (tid-148)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36331 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3476-t148-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 68 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_reboot_router	`Error`	316.33	test_network.py
test_08_start_router	`Error`	73.41	test_routers.py
test_09_reboot_router	`Error`	1.09	test_routers.py
test_02_list_snapshots_with_removed_data_store	`Error`	1.13	test_snapshots.py
test_01_volume_usage	`Error`	9.32	test_usage.py

yadvr · 2019-07-12T06:54:16Z

@shwstppr @anuragaw @borisstoyanov can you review this? The only outstanding issues are the following intermittently failing tests on vmware that I'll confirm manually shortly:


test_reboot_router | Error | 316.33 | test_network.py
-- | -- | -- | --
test_08_start_router | Error | 73.41 | test_routers.py
test_09_reboot_router | Error | 1.09 | test_routers.py
test_02_list_snapshots_with_removed_data_store | Error | 1.13 | test_snapshots.py
test_01_volume_usage | Error | 9.32 | test_usage.py

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2019-07-12T07:27:22Z

Let's review and merge this on next Travis pass @borisstoyanov @shwstppr @anuragaw ?
We can debug and address vmware related failures separately.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2019-07-12T09:28:14Z

@khos2ow the packaging jobs in Travis are failing can you send a separate PR to fix it, for now I've commented them out:
https://travis-ci.org/apache/cloudstack/jobs/557712415
https://travis-ci.org/apache/cloudstack/jobs/557712416

anuragaw

LGTM

yadvr · 2019-07-12T11:54:37Z

shwstppr

LGTM!

ustcweizhou · 2019-07-12T11:58:50Z

good

README: update docs and development INSTALL.md

e8bafe7

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added this to the 4.13.0.0 milestone Jul 8, 2019

Fix listing of tags when resourceid projects is provided

4737149

When resource type project is passed, users shoulnd't need to pass the projectid param, previous tests should pass (test_tags.py). Fixes apache#3377 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr mentioned this pull request Jul 8, 2019

project id added in test #3378

Closed

5 tasks

yadvr added 3 commits July 8, 2019 15:19

fix enum string comparison

fd93619

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

fix equal ignorecase

942c733

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

fix api param usage, id instead of ids while listing tags

f0b160e

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr mentioned this pull request Jul 8, 2019

project tags test fails in all travis runs #3377

Closed

only print failed, errorer test results/cases

d10c8b3

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

ustcweizhou reviewed Jul 8, 2019

View reviewed changes

ustcweizhou approved these changes Jul 9, 2019

View reviewed changes

send hypervisor version, otherwise NPE may occur

8a5176a

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr closed this Jul 9, 2019

yadvr reopened this Jul 9, 2019

apache deleted a comment from blueorangutan Jul 9, 2019

yadvr added 2 commits July 10, 2019 12:14

add missing/new test to travisci

6f81baa

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

use unique tag names per test to avoid intermittent errors

c03af88

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added 2 commits July 11, 2019 13:48

reoptimise regroup...

2ca5c2c

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

again...

2756899

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr closed this Jul 11, 2019

yadvr reopened this Jul 11, 2019

yadvr added 6 commits July 11, 2019 16:35

more fixes

e7674ce

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

more fixes meh

da3fbb0

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

again

f2db872

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

oh Travis gods, please go green this time!

36b318f

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

final optimisation by time

75c7cac

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

go green like hulk!

5f74e9e

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr closed this Jul 12, 2019

yadvr reopened this Jul 12, 2019

anuragaw mentioned this pull request Jul 12, 2019

server: fix the subnet overlap checking logic for tagged and untagged vlans when adding ipranges #3430

Merged

5 tasks

travis get it around or less than 40mins

060c905

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

disable packaging jobs they are failing

1868ce2

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

anuragaw approved these changes Jul 12, 2019

View reviewed changes

shwstppr approved these changes Jul 12, 2019

View reviewed changes

yadvr merged commit 97df529 into apache:master Jul 12, 2019

Conversation

yadvr commented Jul 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Uh oh!

yadvr commented Jul 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ustcweizhou Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

yadvr Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

ustcweizhou Jul 8, 2019

Choose a reason for hiding this comment

Uh oh!

yadvr Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

ustcweizhou Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jul 9, 2019

Uh oh!

blueorangutan commented Jul 9, 2019

Uh oh!

blueorangutan commented Jul 9, 2019

Uh oh!

yadvr commented Jul 9, 2019

Uh oh!

blueorangutan commented Jul 9, 2019

Uh oh!

yadvr commented Jul 9, 2019

Uh oh!

blueorangutan commented Jul 9, 2019

Uh oh!

blueorangutan commented Jul 9, 2019

Uh oh!

blueorangutan commented Jul 10, 2019

Uh oh!

yadvr commented Jul 10, 2019

Uh oh!

blueorangutan commented Jul 10, 2019

Uh oh!

blueorangutan commented Jul 11, 2019

Uh oh!

yadvr commented Jul 11, 2019

Uh oh!

blueorangutan commented Jul 11, 2019

Uh oh!

blueorangutan commented Jul 11, 2019

Uh oh!

yadvr commented Jul 11, 2019

Uh oh!

blueorangutan commented Jul 11, 2019

Uh oh!

blueorangutan commented Jul 11, 2019

Uh oh!

yadvr commented Jul 12, 2019

Uh oh!

yadvr commented Jul 12, 2019

Uh oh!

yadvr commented Jul 12, 2019

Uh oh!

anuragaw left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jul 12, 2019

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

ustcweizhou commented Jul 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

yadvr commented Jul 8, 2019 •

edited

Loading

yadvr commented Jul 8, 2019 •

edited

Loading