Fix 4 findbugs warnings in JuniperSrxResource#399
Closed
rsafonseca wants to merge 1 commit intoapache:masterfrom
Closed
Fix 4 findbugs warnings in JuniperSrxResource#399rsafonseca wants to merge 1 commit intoapache:masterfrom
rsafonseca wants to merge 1 commit intoapache:masterfrom
Conversation
|
cloudstack-pull-requests #374 FAILURE |
Member
|
Patch fails for some reason |
Data should be read and written in UTF-8 to the SRX Buffers were being used for reading but not for writing, PrintWriter was auto-flushing and code was explicitly flushing again, causing unnecessary operation to be performed.
Contributor
Author
|
perhaps due to other changes in base file? I've rebased with current master, can you retry @bhaisaab ? :) |
|
cloudstack-pull-requests #446 SUCCESS |
Member
|
@rsafonseca works now, merging. Thanks for the PRs :) |
kishankavala
pushed a commit
to kishankavala/cloudstack
that referenced
this pull request
Jun 25, 2015
… written in UTF-8 to the SRX Buffers were being used for reading but not for writing, PrintWriter was auto-flushing and code was explicitly flushing again, causing unnecessary operation to be performed. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> This closes apache#399
yadvr
added a commit
that referenced
this pull request
Jan 20, 2021
Fixes #384 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
shwstppr
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Sep 5, 2024
* Log stdout to a file * Add logrotation * Fixup permissions in log file * Remove info logs in stdout * Change output file names Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com> * Fix logrotate config * Disable logging to stdout --------- Co-authored-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data should be read and written in UTF-8 to the SRX
Buffers were being used for reading but not for writing, PrintWriter was auto-flushing and code was explicitly flushing again, causing unnecessary operation to be performed.
Some operations might fail in OS that didn't use UTF-8 as default encoding, such as windows.