api/server: fix hahost value in listHosts by shwstppr · Pull Request #4789 · apache/cloudstack

shwstppr · 2021-03-10T11:02:21Z

Description

Hosts can have multiple tags assigned to them therefore changes have been made to check for all of the host tags if they match ha.tag configuration value.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

With a 2xKVM hosts env with advanced networking
Global config - ha.tag:

(localcloud) SBCM5> > list configurations name=ha.tag
{
  "configuration": [
    {
      "category": "Advanced",
      "description": "HA tag defining that the host marked with this tag can be used for HA purposes only",
      "isdynamic": false,
      "name": "ha.tag",
      "value": "ha"
    }
  ],
  "count": 1
}

Before changes:

(localcloud) SBCM5> > list hosts type='Routing' filter=id,name,hahost,hosttags,hostha
{
  "count": 2,
  "host": [
    {
      "hahost": false,
      "hostha": {
        "haenable": false,
        "hastate": "Disabled"
      },
      "id": "845ba3d4-3c28-497d-a4b5-f3918a3031b3",
      "name": "pr4710-t3640-kvm-centos7-kvm2"
    },
    {
      "hahost": false,
      "hostha": {
        "haenable": false,
        "hastate": "Disabled"
      },
      "hosttags": "test,ha",
      "id": "4937aa4f-6f27-4dc8-af70-2335279edf27",
      "name": "pr4710-t3640-kvm-centos7-kvm1"
    }
  ]
}

After changes:

(localcloud) SBCM5> > list hosts type='Routing' filter=id,name,hahost,hosttags,hostha
{
  "count": 2,
  "host": [
    {
      "hahost": false,
      "hostha": {
        "haenable": false,
        "hastate": "Disabled"
      },
      "id": "845ba3d4-3c28-497d-a4b5-f3918a3031b3",
      "name": "pr4710-t3640-kvm-centos7-kvm2"
    },
    {
      "hahost": true,
      "hostha": {
        "haenable": false,
        "hastate": "Disabled"
      },
      "hosttags": "test,ha",
      "id": "4937aa4f-6f27-4dc8-af70-2335279edf27",
      "name": "pr4710-t3640-kvm-centos7-kvm1"
    }
  ]
}

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

weizhouapache · 2021-03-10T11:35:28Z

@shwstppr
I think it would be better to remove host_tags.tag from host_view. but it requires db change.

server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java

shwstppr · 2021-03-11T07:23:42Z

@shwstppr
I think it would be better to remove host_tags.tag from host_view. but it requires db change.

@weizhouapache we re-create host_view to have concatenated tags with the following changes maybe in 4.16?

DROP VIEW IF EXISTS `cloud`.`host_view`;
CREATE VIEW `cloud`.`host_view` AS
    SELECT
        host.id,
        host.uuid,
        host.name,
        host.status,
        host.disconnected,
        host.type,
        host.private_ip_address,
        host.version,
        host.hypervisor_type,
        host.hypervisor_version,
        host.capabilities,
        host.last_ping,
        host.created,
        host.removed,
        host.resource_state,
        host.mgmt_server_id,
        host.cpu_sockets,
        host.cpus,
        host.speed,
        host.ram,
        cluster.id cluster_id,
        cluster.uuid cluster_uuid,
        cluster.name cluster_name,
        cluster.cluster_type,
        data_center.id data_center_id,
        data_center.uuid data_center_uuid,
        data_center.name data_center_name,
        data_center.networktype data_center_type,
        host_pod_ref.id pod_id,
        host_pod_ref.uuid pod_uuid,
        host_pod_ref.name pod_name,
        GROUP_CONCAT(DISTINCT(host_tags.tag)) AS tag,
        guest_os_category.id guest_os_category_id,
        guest_os_category.uuid guest_os_category_uuid,
        guest_os_category.name guest_os_category_name,
        mem_caps.used_capacity memory_used_capacity,
        mem_caps.reserved_capacity memory_reserved_capacity,
        cpu_caps.used_capacity cpu_used_capacity,
        cpu_caps.reserved_capacity cpu_reserved_capacity,
        async_job.id job_id,
        async_job.uuid job_uuid,
        async_job.job_status job_status,
        async_job.account_id job_account_id,
        oobm.enabled AS `oobm_enabled`,
        oobm.power_state AS `oobm_power_state`,
        ha_config.enabled AS `ha_enabled`,
        ha_config.ha_state AS `ha_state`,
        ha_config.provider AS `ha_provider`,
        `last_annotation_view`.`annotation` AS `annotation`,
        `last_annotation_view`.`created` AS `last_annotated`,
        `user`.`username` AS `username`
    FROM
        `cloud`.`host`
            LEFT JOIN
        `cloud`.`cluster` ON host.cluster_id = cluster.id
            LEFT JOIN
        `cloud`.`data_center` ON host.data_center_id = data_center.id
            LEFT JOIN
        `cloud`.`host_pod_ref` ON host.pod_id = host_pod_ref.id
            LEFT JOIN
        `cloud`.`host_details` ON host.id = host_details.host_id
            AND host_details.name = 'guest.os.category.id'
            LEFT JOIN
        `cloud`.`guest_os_category` ON guest_os_category.id = CONVERT ( host_details.value, UNSIGNED )
            LEFT JOIN
        `cloud`.`host_tags` ON host_tags.host_id = host.id
            LEFT JOIN
        `cloud`.`op_host_capacity` mem_caps ON host.id = mem_caps.host_id
            AND mem_caps.capacity_type = 0
            LEFT JOIN
        `cloud`.`op_host_capacity` cpu_caps ON host.id = cpu_caps.host_id
            AND cpu_caps.capacity_type = 1
            LEFT JOIN
        `cloud`.`async_job` ON async_job.instance_id = host.id
            AND async_job.instance_type = 'Host'
            AND async_job.job_status = 0
            LEFT JOIN
        `cloud`.`oobm` ON oobm.host_id = host.id
            left join
        `cloud`.`ha_config` ON ha_config.resource_id=host.id
            and ha_config.resource_type='Host'
            LEFT JOIN
        `cloud`.`last_annotation_view` ON `last_annotation_view`.`entity_uuid` = `host`.`uuid`
            LEFT JOIN
        `cloud`.`user` ON `user`.`uuid` = `last_annotation_view`.`user_uuid`
    GROUP BY
        `host`.`id`;

weizhouapache · 2021-03-11T10:36:47Z

@shwstppr
I think it would be better to remove host_tags.tag from host_view. but it requires db change.

@weizhouapache we re-create host_view to have concatenated tags with the following changes maybe in 4.16?

DROP VIEW IF EXISTS `cloud`.`host_view`;
CREATE VIEW `cloud`.`host_view` AS
    SELECT
        host.id,
        host.uuid,
        host.name,
        host.status,
        host.disconnected,
        host.type,
        host.private_ip_address,
        host.version,
        host.hypervisor_type,
        host.hypervisor_version,
        host.capabilities,
        host.last_ping,
        host.created,
        host.removed,
        host.resource_state,
        host.mgmt_server_id,
        host.cpu_sockets,
        host.cpus,
        host.speed,
        host.ram,
        cluster.id cluster_id,
        cluster.uuid cluster_uuid,
        cluster.name cluster_name,
        cluster.cluster_type,
        data_center.id data_center_id,
        data_center.uuid data_center_uuid,
        data_center.name data_center_name,
        data_center.networktype data_center_type,
        host_pod_ref.id pod_id,
        host_pod_ref.uuid pod_uuid,
        host_pod_ref.name pod_name,
        GROUP_CONCAT(DISTINCT(host_tags.tag)) AS tag,
        guest_os_category.id guest_os_category_id,
        guest_os_category.uuid guest_os_category_uuid,
        guest_os_category.name guest_os_category_name,
        mem_caps.used_capacity memory_used_capacity,
        mem_caps.reserved_capacity memory_reserved_capacity,
        cpu_caps.used_capacity cpu_used_capacity,
        cpu_caps.reserved_capacity cpu_reserved_capacity,
        async_job.id job_id,
        async_job.uuid job_uuid,
        async_job.job_status job_status,
        async_job.account_id job_account_id,
        oobm.enabled AS `oobm_enabled`,
        oobm.power_state AS `oobm_power_state`,
        ha_config.enabled AS `ha_enabled`,
        ha_config.ha_state AS `ha_state`,
        ha_config.provider AS `ha_provider`,
        `last_annotation_view`.`annotation` AS `annotation`,
        `last_annotation_view`.`created` AS `last_annotated`,
        `user`.`username` AS `username`
    FROM
        `cloud`.`host`
            LEFT JOIN
        `cloud`.`cluster` ON host.cluster_id = cluster.id
            LEFT JOIN
        `cloud`.`data_center` ON host.data_center_id = data_center.id
            LEFT JOIN
        `cloud`.`host_pod_ref` ON host.pod_id = host_pod_ref.id
            LEFT JOIN
        `cloud`.`host_details` ON host.id = host_details.host_id
            AND host_details.name = 'guest.os.category.id'
            LEFT JOIN
        `cloud`.`guest_os_category` ON guest_os_category.id = CONVERT ( host_details.value, UNSIGNED )
            LEFT JOIN
        `cloud`.`host_tags` ON host_tags.host_id = host.id
            LEFT JOIN
        `cloud`.`op_host_capacity` mem_caps ON host.id = mem_caps.host_id
            AND mem_caps.capacity_type = 0
            LEFT JOIN
        `cloud`.`op_host_capacity` cpu_caps ON host.id = cpu_caps.host_id
            AND cpu_caps.capacity_type = 1
            LEFT JOIN
        `cloud`.`async_job` ON async_job.instance_id = host.id
            AND async_job.instance_type = 'Host'
            AND async_job.job_status = 0
            LEFT JOIN
        `cloud`.`oobm` ON oobm.host_id = host.id
            left join
        `cloud`.`ha_config` ON ha_config.resource_id=host.id
            and ha_config.resource_type='Host'
            LEFT JOIN
        `cloud`.`last_annotation_view` ON `last_annotation_view`.`entity_uuid` = `host`.`uuid`
            LEFT JOIN
        `cloud`.`user` ON `user`.`uuid` = `last_annotation_view`.`user_uuid`
    GROUP BY
        `host`.`id`;

@shwstppr yeah, 4.16 or 4.15.1.

I suggest to remove tags (resource tags, host tags, etc) from all mysql views.
Assume there are 10 tags, the mysql view with tags will be 10 times larger than the mysql view without tags.
we can easily get and set all tags by a mysql query.

shwstppr · 2021-03-11T11:17:11Z

@weizhouapache with above SQL create view statement we will have a single entry for each host with multiple tags comma-separated. Something like,

*************************** 1. row ***************************
                      id: 1
                    uuid: 4937aa4f-6f27-4dc8-af70-2335279edf27
                    name: pr4710-t3640-kvm-centos7-kvm1
                  status: Disconnected
            disconnected: NULL
                    type: Routing
      private_ip_address: 10.10.3.146
                 version: 4.15.1.0-SNAPSHOT
         hypervisor_type: KVM
      hypervisor_version: NULL
            capabilities: hvm,snapshot
               last_ping: 1577598635
                 created: 2021-03-03 06:09:26
                 removed: NULL
          resource_state: Enabled
          mgmt_server_id: NULL
             cpu_sockets: 3
                    cpus: 3
                   speed: 2350
                     ram: 7277121536
              cluster_id: 1
            cluster_uuid: 881c01ec-7a4b-4c55-af5c-d53de5880b5e
            cluster_name: p1-c1
            cluster_type: CloudManaged
          data_center_id: 1
        data_center_uuid: 3f4d015c-7d6b-4b5e-86b0-79552910f77b
        data_center_name: pr4710-t3640-kvm-centos7
        data_center_type: Advanced
                  pod_id: 1
                pod_uuid: 496029eb-411a-4736-954d-73d5a8d15e56
                pod_name: Pod1
                     tag: test,ha
    guest_os_category_id: NULL
  guest_os_category_uuid: NULL
  guest_os_category_name: NULL
    memory_used_capacity: 268435456
memory_reserved_capacity: 0
       cpu_used_capacity: 500
   cpu_reserved_capacity: 0
                  job_id: NULL
                job_uuid: NULL
              job_status: NULL
          job_account_id: NULL
            oobm_enabled: NULL
        oobm_power_state: NULL
              ha_enabled: NULL
                ha_state: NULL
             ha_provider: NULL
              annotation: NULL
          last_annotated: NULL
                username: NULL

weizhouapache · 2021-03-11T11:23:17Z

@weizhouapache with above SQL create view statement we will have a single entry for each host with multiple tags comma-separated. Something like,

*************************** 1. row ***************************
                      id: 1
                    uuid: 4937aa4f-6f27-4dc8-af70-2335279edf27
                    name: pr4710-t3640-kvm-centos7-kvm1
                  status: Disconnected
            disconnected: NULL
                    type: Routing
      private_ip_address: 10.10.3.146
                 version: 4.15.1.0-SNAPSHOT
         hypervisor_type: KVM
      hypervisor_version: NULL
            capabilities: hvm,snapshot
               last_ping: 1577598635
                 created: 2021-03-03 06:09:26
                 removed: NULL
          resource_state: Enabled
          mgmt_server_id: NULL
             cpu_sockets: 3
                    cpus: 3
                   speed: 2350
                     ram: 7277121536
              cluster_id: 1
            cluster_uuid: 881c01ec-7a4b-4c55-af5c-d53de5880b5e
            cluster_name: p1-c1
            cluster_type: CloudManaged
          data_center_id: 1
        data_center_uuid: 3f4d015c-7d6b-4b5e-86b0-79552910f77b
        data_center_name: pr4710-t3640-kvm-centos7
        data_center_type: Advanced
                  pod_id: 1
                pod_uuid: 496029eb-411a-4736-954d-73d5a8d15e56
                pod_name: Pod1
                     tag: test,ha
    guest_os_category_id: NULL
  guest_os_category_uuid: NULL
  guest_os_category_name: NULL
    memory_used_capacity: 268435456
memory_reserved_capacity: 0
       cpu_used_capacity: 500
   cpu_reserved_capacity: 0
                  job_id: NULL
                job_uuid: NULL
              job_status: NULL
          job_account_id: NULL
            oobm_enabled: NULL
        oobm_power_state: NULL
              ha_enabled: NULL
                ha_state: NULL
             ha_provider: NULL
              annotation: NULL
          last_annotated: NULL
                username: NULL

@shwstppr it looks perfect.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-03-11T12:50:54Z

@weizhouapache I've created PR #4796 against 4.15 to recreate hosts_view in 4.15.1. I will do some more testing before marking it ready for review
We can use fixes in this PR to address the issue in the 4.14.2 or else close this.
cc @rhtyd

weizhouapache

code lgtm

Does #4796 have conflict with this ?

shwstppr · 2021-03-12T07:38:14Z

@weizhouapache yes #4796 will conflict in the current form. I'll rebase my changes there if this is accepted.

DaanHoogland · 2021-03-15T16:28:14Z

clgtm

shwstppr · 2021-03-18T05:31:33Z

@blueorangutan package

blueorangutan · 2021-03-18T05:32:51Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-18T05:51:05Z

Packaging result: ✔️ centos7 ✖️ centos8 ✔️ debian. SL-JID 164

yadvr · 2021-03-18T07:44:52Z

@blueorangutan test

blueorangutan · 2021-03-18T07:46:02Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests [S]

yadvr · 2021-03-22T06:48:27Z

@blueorangutan package

blueorangutan · 2021-03-22T06:49:03Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-03-22T08:08:39Z

Packaging result: ✔️ centos7 ✖️ centos8 ✔️ debian. SL-JID 200

yadvr · 2021-03-24T07:00:57Z

@blueorangutan test

blueorangutan · 2021-03-24T07:02:07Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Co-authored-by: dahn <daan.hoogland@gmail.com>

blueorangutan · 2021-03-27T18:40:03Z

Trillian test result (tid-274)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 100997 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4789-t274-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 28 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestAccounts>:setup	`Error`	0.00	test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup	`Error`	0.00	test_accounts.py
test_DeleteDomain	`Error`	0.70	test_accounts.py
test_forceDeleteDomain	`Failure`	0.74	test_accounts.py
test_forceDeleteDomain	`Error`	2.87	test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup	`Error`	4.91	test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup	`Error`	0.00	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	`Error`	35.34	test_affinity_groups.py
ContextSuite context=TestAsyncJob>:setup	`Error`	0.00	test_async_job.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
test_list_clusters_metrics	`Error`	1511.39	test_metrics_api.py
test_list_vms_metrics	`Error`	0.11	test_metrics_api.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
ContextSuite context=TestDeployVMFromISO>:setup	`Error`	0.00	test_deploy_vm_iso.py
ContextSuite context=TestNetworkACL>:setup	`Error`	0.00	test_network_acl.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup	`Error`	0.00	test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDeployVmWithUserData>:setup	`Error`	0.00	test_deploy_vm_with_userdata.py
test_delete_account	`Error`	1511.24	test_network.py
test_delete_network_while_vm_on_it	`Error`	0.04	test_network.py
test_deploy_vm_l2network	`Error`	0.05	test_network.py
test_l2network_restart	`Error`	1.10	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	3.26	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	0.87	test_network.py
test_reboot_router	`Error`	0.03	test_network.py
test_releaseIP	`Error`	0.37	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	0.41	test_network.py
ContextSuite context=TestRemoteDiagnostics>:setup	`Error`	0.00	test_diagnostics.py
ContextSuite context=TestAdapterTypeForNic>:setup	`Error`	0.00	test_nic_adapter_type.py
ContextSuite context=TestDomainsServiceOfferings>:setup	`Error`	1515.48	test_domain_service_offerings.py
ContextSuite context=TestInternalLb>:setup	`Error`	0.00	test_internal_lb.py
test_01_create_iso_with_checksum_sha1	`Error`	65.33	test_iso.py
test_02_create_iso_with_checksum_sha256	`Error`	65.31	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	65.33	test_iso.py
test_04_create_iso_with_no_checksum	`Error`	65.35	test_iso.py
test_01_create_iso	`Failure`	1515.34	test_iso.py
ContextSuite context=TestISO>:setup	`Error`	3027.72	test_iso.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_deploy_kubernetes_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version	`Error`	60.52	test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_nic_secondaryip_add_remove	`Error`	1511.75	test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup	`Error`	0.00	test_nested_virtualization.py
ContextSuite context=TestPortForwardingRules>:setup	`Error`	0.00	test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup	`Error`	0.00	test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup	`Error`	1517.13	test_projects.py
test_04_rvpc_network_garbage_collector_nics	`Failure`	273.87	test_vpc_redundant.py
test_hostha_kvm_host_degraded	`Failure`	668.13	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Failure`	641.67	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Failure`	645.52	test_hostha_kvm.py

yadvr · 2021-03-29T10:50:53Z

@blueorangutan package

blueorangutan · 2021-03-29T10:52:04Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-03-29T11:55:27Z

Packaging result: ✔️ centos7 ✔️ debian. SL-JID 276

Pearl1594 · 2021-03-29T11:56:32Z

@blueorangutan test

blueorangutan · 2021-03-29T11:57:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-29T12:49:18Z

Trillian Build Failed (tid-283)

Pearl1594 · 2021-03-29T12:51:08Z

@blueorangutan test

blueorangutan · 2021-03-29T12:52:04Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-29T14:23:48Z

Trillian Build Failed (tid-292)

Pearl1594 · 2021-03-29T16:29:06Z

@blueorangutan test

blueorangutan · 2021-03-29T16:30:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-30T06:38:45Z

Trillian test result (tid-297)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48229 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4789-t297-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 65 look OK, 18 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	0.14	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	0.12	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	1.22	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.10	test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
test_02_create_template_with_checksum_sha1	`Error`	65.70	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.39	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.39	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.42	test_templates.py
test_04_extract_template	`Failure`	128.29	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_01_volume_usage	`Error`	186.66	test_usage.py
test_01_migrate_VM_and_root_volume	`Error`	75.33	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	49.06	test_vm_life_cycle.py
test_10_attachAndDetach_iso	`Failure`	1511.54	test_vm_life_cycle.py
test_06_download_detached_volume	`Failure`	137.56	test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible	`Error`	1511.36	test_hostha_kvm.py

shwstppr · 2021-03-31T04:09:46Z

@blueorangutan package

blueorangutan · 2021-03-31T04:10:03Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-03-31T04:16:58Z

Packaging result: ✖️ centos7 ✖️ debian. SL-JID 289

blueorangutan · 2021-03-31T04:16:58Z

Packaging result: ✖️ centos7 ✖️ debian. SL-JID 287

blueorangutan · 2021-03-31T04:28:16Z

Packaging result: ✔️ centos7 ✔️ debian. SL-JID 292

Pearl1594 · 2021-03-31T04:32:37Z

@blueorangutan test

blueorangutan · 2021-03-31T04:33:02Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-31T15:33:17Z

Trillian test result (tid-305)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37788 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4789-t305-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	78.66	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	51.27	test_vm_life_cycle.py

* api/server: fix hahost value in listHosts Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * Update server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java Co-authored-by: dahn <daan.hoogland@gmail.com> * Update server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: dahn <daan.hoogland@gmail.com>

api/server: fix hahost value in listHosts

8e041a7

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr changed the base branch from master to 4.14 March 10, 2021 11:02

shwstppr mentioned this pull request Mar 10, 2021

Host HA is configre fail #3717

Closed

GutoVeronezi reviewed Mar 10, 2021

View reviewed changes

server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java Outdated Show resolved Hide resolved

yadvr added this to the 4.15.1.0 milestone Mar 11, 2021

fix

5163fe0

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

weizhouapache approved these changes Mar 11, 2021

View reviewed changes

apache deleted a comment from blueorangutan Mar 18, 2021

yadvr requested review from Pearl1594 and Spaceman1984 March 24, 2021 07:00

Update server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java

e8501a0

Co-authored-by: dahn <daan.hoogland@gmail.com>

apache deleted a comment from blueorangutan Mar 31, 2021

apache deleted a comment from Pearl1594 Mar 31, 2021

apache deleted a comment from blueorangutan Mar 31, 2021

apache deleted a comment from Pearl1594 Mar 31, 2021

yadvr approved these changes Apr 1, 2021

View reviewed changes

yadvr merged commit 95cd937 into apache:4.14 Apr 1, 2021

weizhouapache mentioned this pull request Apr 1, 2021

db, server: refactor host_view to prevent duplicate entries #4796

Merged

12 tasks

mredaelli02 mentioned this pull request Dec 9, 2024

HA Host Tag Behavior Inconsistency with multiple tags #10070

Closed

Conversation

shwstppr commented Mar 10, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Mar 10, 2021

Uh oh!

Uh oh!

shwstppr commented Mar 11, 2021

Uh oh!

weizhouapache commented Mar 11, 2021

Uh oh!

shwstppr commented Mar 11, 2021

Uh oh!

weizhouapache commented Mar 11, 2021

Uh oh!

shwstppr commented Mar 11, 2021

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Mar 12, 2021

Uh oh!

DaanHoogland commented Mar 15, 2021

Uh oh!

shwstppr commented Mar 18, 2021

Uh oh!

blueorangutan commented Mar 18, 2021

Uh oh!

blueorangutan commented Mar 18, 2021

Uh oh!

yadvr commented Mar 18, 2021

Uh oh!

blueorangutan commented Mar 18, 2021

Uh oh!

yadvr commented Mar 22, 2021

Uh oh!

blueorangutan commented Mar 22, 2021

Uh oh!

blueorangutan commented Mar 22, 2021

Uh oh!

yadvr commented Mar 24, 2021

Uh oh!

blueorangutan commented Mar 24, 2021

Uh oh!

blueorangutan commented Mar 27, 2021

Uh oh!

yadvr commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

Pearl1594 commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

Pearl1594 commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

Pearl1594 commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 30, 2021

Uh oh!

shwstppr commented Mar 31, 2021

Uh oh!

blueorangutan commented Mar 31, 2021

Uh oh!