Skip to content

UI - zone wizard - fix undefined property when setting RBD primary storage#5167

Merged
sureshanaparti merged 2 commits intoapache:mainfrom
utchoang:feature/fix-zone-wizard-primary-storage
Jul 9, 2021
Merged

UI - zone wizard - fix undefined property when setting RBD primary storage#5167
sureshanaparti merged 2 commits intoapache:mainfrom
utchoang:feature/fix-zone-wizard-primary-storage

Conversation

@utchoang
Copy link

@utchoang utchoang commented Jun 30, 2021

Description

Fixes #5166

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang
Copy link
Author

utchoang commented Jun 30, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jun 30, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jun 30, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5167 (SL-JID-298)

shwstppr
shwstppr approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM
Minor suggestion if we want to address #4956 these changes can be modified to
let path = this.prefillContent.primaryStoragePath?.value || ''

@davidjumani
Copy link
Contributor

davidjumani commented Jul 1, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 1, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 1, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5167 (SL-JID-304)

@yadvr yadvr added this to the 4.16.0.0 milestone Jul 5, 2021
@yadvr
Copy link
Member

yadvr commented Jul 5, 2021

LGTM

GabrielBrascher
GabrielBrascher approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Jul 9, 2021

Merging this based on approvals, and reviews.

@sureshanaparti sureshanaparti merged commit f7cc3c9 into apache:main Jul 9, 2021
@utchoang utchoang deleted the feature/fix-zone-wizard-primary-storage branch July 12, 2021 07:36
@nvazquez nvazquez mentioned this pull request Jul 13, 2021
Closed
@dhslove dhslove mentioned this pull request May 23, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

@davidjumani davidjumani Awaiting requested review from davidjumani

@yadvr yadvr Awaiting requested review from yadvr

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

[UI] Cannot use RBD primary storage when adding ZONE

7 participants

@utchoang @blueorangutan @davidjumani @yadvr @sureshanaparti @shwstppr @GabrielBrascher