under windows environment the publicKeyPath and privateKeyPath should replace from \...#66
under windows environment the publicKeyPath and privateKeyPath should replace from \...#66cloudtrends wants to merge 3 commits intoapache:masterfrom
Conversation
…m \ to / when send them into injectkeys.py
There was a problem hiding this comment.
There is an isOnWindows() function in this class which can be reused
There was a problem hiding this comment.
Hi karuturi ,
thanks for your kindly help , yes , I should use the isOnWindows function .
ChunFeng
|
In case of windows, python scripts are executed and I think it runs fine from cygwin. Is this change targeted to make it work from cmd? |
…m \ to / when send them into injectkeys.py , and use isOnWindows function . thanks karuturi kindly tips.
|
My test environment is on Windows 2008 & cygwin 64 bits version . I can reoccur the error's by below python scripts: --------------------------- cygwin_python_test.py ------------------- test it by , touch a file : F:/sourcecode/python/a-exist.txt First test with Backslash : Then with slash : $ python cygwin_python_test.py F:/sourcecode/python/a-exist.txt So , I thinks we should change the backslash to slash in windows environment . |
|
Hi karuturi , thanks for point out that I should use isOnWindows function , very appreciation. ChunFeng |
|
Thanks for the patch. Agree to the slash change. I am pushing this to master(4.6). Let me know if you want it on any other branch. |
…m \ to / when send them into injectkeys.py , and use isOnWindows function . thanks karuturi kindly tips. Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com> This closes #66
Fixes #46 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Under windows environment the publicKeyPath and privateKeyPath should replace from \ to / when send them into injectkeys.py