Add domainpath to listnetwork and UI network tab#7386
Add domainpath to listnetwork and UI network tab#7386DaanHoogland merged 7 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
|
Kudos, SonarCloud Quality Gate passed! |
|
is this ready for review @pierrelefevre ? |
|
Yeah, should be! |
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 5830 |
Codecov Report
@@ Coverage Diff @@
## main #7386 +/- ##
============================================
- Coverage 29.11% 28.43% -0.68%
+ Complexity 30345 29274 -1071
============================================
Files 5100 5100
Lines 358542 358547 +5
Branches 52314 52314
============================================
- Hits 104399 101970 -2429
- Misses 239800 242583 +2783
+ Partials 14343 13994 -349
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 215 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@blueorangutan package |
|
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5901 |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-6416)
|
api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java
Outdated
Show resolved
Hide resolved
|
@shwstppr Should be fixed now! |
|
@blueorangutan package |
|
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7195 |
|
@blueorangutan LLpackage |
|
@DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6190 |
|
@blueorangutan LLtest matrix |
|
@DaanHoogland a [LL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests |
|
[LL] Trillian Build Failed (tid-6761) |
|
[LL]Trillian test result (tid-6760)
|
|
[LL]Trillian test result (tid-6762)
|
|
[LL]Trillian test result (tid-6767)
|
|
@weizhouapache can you please re-review? |
|
code lgtm I think we could add the field to the interface ControlledEntityResponse, and expose domainpath to all entities. |
I see your point @weizhouapache : should for this refuse the PR as is or can we merge and create follow up (an) issue(s)? |
|
I'm okay with merging this and work on follow-up |
I am ok with it |
|
Awesome work, congrats on your first merged pull request! |








Description
This PR...
Fixes: #7363
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested in UI and using cloudmonkey