NSX Integration fixes by Pearl1594 · Pull Request #8906 · apache/cloudstack

Pearl1594 · 2024-04-12T14:12:02Z

Description

This PR addresses issues identified in #7919

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…behind on scale down (#32)

* Fix concurrency issues on port forwarding rules deletion * Refactor objectExists * Fix unit test * Fix test * Small fixes

…tion attempts (#38)

…tover rules on CKS cluster deletion (#45) * Fix pf rules removal on CKS cluster deletion * Fix check for number of physical networks for guest traffic * Fix unit test

codecov-commenter · 2024-04-12T16:02:35Z

Codecov Report

Attention: Patch coverage is 22.16749% with 158 lines in your changes missing coverage. Please review.

Project coverage is 15.76%. Comparing base (f683d2d) to head (d1a6038).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...va/org/apache/cloudstack/service/NsxApiClient.java	11.86%	50 Missing and 2 partials ⚠️
...java/org/apache/cloudstack/service/NsxElement.java	47.69%	24 Missing and 10 partials ⚠️
...va/org/apache/cloudstack/resource/NsxResource.java	11.11%	14 Missing and 2 partials ⚠️
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java	0.00%	15 Missing ⚠️
...KubernetesClusterResourceModifierActionWorker.java	0.00%	10 Missing ⚠️
.../org/apache/cloudstack/service/NsxServiceImpl.java	11.11%	8 Missing ⚠️
...src/main/java/org/apache/cloudstack/NsxAnswer.java	0.00%	6 Missing ⚠️
...cloudstack/affinity/HostAntiAffinityProcessor.java	0.00%	4 Missing ⚠️
...loudstack/resourcedetail/FirewallRuleDetailVO.java	0.00%	3 Missing ⚠️
...che/cloudstack/affinity/HostAffinityProcessor.java	25.00%	2 Missing and 1 partial ⚠️
... and 6 more

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #8906     +/-   ##
===========================================
  Coverage     15.76%   15.76%             
  Complexity    12507    12507             
===========================================
  Files          5619     5620      +1     
  Lines        491156   491268    +112     
  Branches      60118    62845   +2727     
===========================================
+ Hits          77418    77437     +19     
- Misses       405282   405369     +87     
- Partials       8456     8462      +6

Flag	Coverage Δ
uitests	`4.05% <ø> (ø)`
unittests	`16.57% <22.16%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pearl1594 · 2024-04-12T16:27:17Z

@blueorangutan package

blueorangutan · 2024-04-12T16:28:03Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-12T17:35:11Z

Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 9237

Pearl1594 · 2024-04-12T17:37:06Z

@blueorangutan package

blueorangutan · 2024-04-12T17:38:03Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-12T18:48:06Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9238

nvazquez · 2024-04-12T21:23:02Z

@blueorangutan test matrix

blueorangutan · 2024-04-12T21:24:03Z

@nvazquez a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-04-13T09:44:36Z

[SF] Trillian test result (tid-9820)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42335 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t9820-kvm-centos7.zip
Smoke tests completed. 122 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	299.84	test_events_resource.py
test_01_events_resource	`Error`	299.85	test_events_resource.py
test_DeployVmAntiAffinityGroup_in_project	`Error`	88.96	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	`Error`	37.64	test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	26.81	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.06	test_kubernetes_clusters.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	82.31	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.33	test_network_permissions.py
test_01_non_strict_host_anti_affinity	`Failure`	123.30	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	81.26	test_nonstrict_affinity_group.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	305.87	test_hostha_kvm.py

blueorangutan · 2024-04-13T10:21:19Z

[SF] Trillian test result (tid-9818)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45078 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t9818-xenserver-71.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	223.19	test_events_resource.py
test_01_events_resource	`Error`	223.20	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	108.97	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.41	test_network_permissions.py

blueorangutan · 2024-04-13T14:45:41Z

[SF] Trillian test result (tid-9819)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 60880 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t9819-vmware-67u3.zip
Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	204.07	test_events_resource.py
test_01_events_resource	`Error`	204.07	test_events_resource.py
test_list_vms_metrics_admin	`Error`	3621.84	test_metrics_api.py
test_list_vms_metrics_history	`Error`	4.70	test_metrics_api.py
test_list_volumes_metrics_history	`Error`	3618.82	test_metrics_api.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	99.17	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.46	test_network_permissions.py

… on APIs * NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs * Remove unused string

…integration-fixes

Pearl1594 · 2024-06-05T15:52:34Z

@blueorangutan package

blueorangutan · 2024-06-05T15:54:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

nvazquez · 2024-09-05T18:16:14Z

@blueorangutan package

blueorangutan · 2024-09-05T18:18:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-05T19:35:00Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11019

Pearl1594 · 2024-09-05T19:38:16Z

@blueorangutan test matrix

blueorangutan · 2024-09-05T19:40:06Z

@Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

alexandremattioli

LGTM

nvazquez · 2024-09-06T01:42:31Z

Hi @rohityadavcloud this PR is ready (waiting for test results)

github-actions · 2024-09-06T05:26:19Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

yadvr · 2024-09-06T06:22:01Z

Just to check build:
@blueorangutan package

blueorangutan · 2024-09-06T06:24:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2024-09-06T07:14:43Z

Quality Gate failed

Failed conditions
16.1% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

DaanHoogland · 2024-09-06T07:23:01Z

@Pearl1594 , how critical are these fixes ?

blueorangutan · 2024-09-06T07:49:04Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11025

blueorangutan · 2024-09-06T10:20:27Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11036

yadvr · 2024-09-06T10:26:32Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2024-09-06T10:28:09Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2024-09-06T13:41:19Z

[SF] Trillian test result (tid-11390)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50298 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t11390-kvm-ol8.zip
Smoke tests completed. 139 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_mount_shared_fs	`Failure`	94.29	test_sharedfs_lifecycle.py
test_resize_shared_fs	`Error`	0.24	test_sharedfs_lifecycle.py

blueorangutan · 2024-09-06T14:31:53Z

[SF] Trillian test result (tid-11391)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 53333 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t11391-kvm-ubuntu22.zip
Smoke tests completed. 138 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_mount_shared_fs	`Failure`	83.02	test_sharedfs_lifecycle.py
test_resize_shared_fs	`Error`	0.23	test_sharedfs_lifecycle.py

blueorangutan · 2024-09-06T20:10:21Z

[SF] Trillian test result (tid-11392)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 71001 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t11392-vmware-70u3.zip
Smoke tests completed. 129 look OK, 4 have errors, 7 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_deploy_more_vms_than_limit_allows	`Error`	141.10	test_deploy_vms_in_parallel.py
test_01_deployVMInSharedNetwork	`Failure`	3603.99	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown	`Error`	3605.20	test_network.py
test_02_restore_vm_with_disk_offering	`Error`	62.19	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	`Error`	55.12	test_restore_vm.py
test_mount_shared_fs	`Failure`	95.18	test_sharedfs_lifecycle.py
test_resize_shared_fs	`Error`	0.23	test_sharedfs_lifecycle.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

blueorangutan · 2024-09-07T00:11:10Z

[SF] Trillian test result (tid-11393)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9
Total time taken: 78430 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t11393-xcpng82.zip
Smoke tests completed. 135 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	`Failure`	172.04	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Failure`	184.20	test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	7.42	test_network.py
test_01_non_strict_host_anti_affinity	`Error`	220.56	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	124.48	test_nonstrict_affinity_group.py
test_02_create_volume	`Error`	2.20	test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change	`Failure`	70.43	test_scale_vm.py

blueorangutan · 2024-09-07T02:36:54Z

[SF] Trillian test result (tid-11412)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 43913 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8906-t11412-vmware-70u3.zip
Smoke tests completed. 112 look OK, 29 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deployVMInSharedNetwork	`Error`	346.89	test_network.py
test_02_restore_vm_with_disk_offering	`Error`	53.98	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	`Error`	56.99	test_restore_vm.py
test_01_prepare_and_cancel_shutdown	`Error`	2.54	test_safe_shutdown.py
test_02_trigger_shutdown	`Failure`	301.48	test_safe_shutdown.py
test_01_scale_vm	`Error`	0.02	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	`Error`	0.02	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	`Error`	0.01	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	2.68	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	2.68	test_scale_vm.py
test_05_scale_vm_dont_allow_disk_offering_change	`Error`	0.07	test_scale_vm.py
ContextSuite context=TestScaleVm>:teardown	`Error`	0.18	test_scale_vm.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	3.09	test_service_offerings.py
test_01_create_webhook_admin_local	`Error`	0.11	test_webhook_lifecycle.py
test_02_create_webhook_admin_domain	`Error`	0.12	test_webhook_lifecycle.py
test_03_create_webhook_admin_global	`Error`	0.12	test_webhook_lifecycle.py
test_04_create_webhook_domainadmin_local	`Error`	3.42	test_webhook_lifecycle.py
test_05_create_webhook_domainadmin_subdomain	`Error`	3.20	test_webhook_lifecycle.py
test_06_create_webhook_domainadmin_global_negative	`Error`	3.33	test_webhook_lifecycle.py
test_07_create_webhook_user_local	`Error`	3.17	test_webhook_lifecycle.py
test_08_create_webhook_user_domain	`Error`	3.15	test_webhook_lifecycle.py
test_09_create_webhook_user_gloabl	`Error`	2.74	test_webhook_lifecycle.py
test_10_create_webhook_admin_advanced	`Error`	3.01	test_webhook_lifecycle.py
test_11_update_webhook	`Error`	3.28	test_webhook_lifecycle.py
test_12_list_user_webhook_deliveries	`Error`	8.19	test_webhook_lifecycle.py
test_13_webhook_execute_delivery	`Error`	3.53	test_webhook_lifecycle.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py
ContextSuite context=TestSharedFSLifecycle>:setup	`Error`	0.00	test_sharedfs_lifecycle.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
test_05_stop_ssvm	`Error`	0.09	test_ssvm.py
test_06_stop_cpvm	`Error`	0.10	test_ssvm.py
test_07_reboot_ssvm	`Error`	0.09	test_ssvm.py
test_08_reboot_cpvm	`Error`	0.09	test_ssvm.py
test_09_reboot_ssvm_forced	`Error`	0.09	test_ssvm.py
test_10_reboot_cpvm_forced	`Error`	0.11	test_ssvm.py
test_11_destroy_ssvm	`Error`	0.09	test_ssvm.py
test_12_destroy_cpvm	`Error`	0.08	test_ssvm.py
test_01_import_storage_policies	`Error`	4.67	test_storage_policy.py
ContextSuite context=TestVMWareStoragePolicies>:teardown	`Error`	4.71	test_storage_policy.py
ContextSuite context=TestCopyAndDeleteTemplatesAcrossZones>:setup	`Error`	0.00	test_templates.py
ContextSuite context=TestCreateTemplate>:setup	`Error`	0.00	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	6.08	test_templates.py
test_01_positive_tests_usage	`Failure`	2.70	test_usage_events.py
test_01_positive_tests_usage	`Error`	2.71	test_usage_events.py
test_01_ISO_usage	`Error`	0.03	test_usage.py
ContextSuite context=TestISOUsage>:teardown	`Error`	0.06	test_usage.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	3.04	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	6.03	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	8.77	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	11.56	test_usage.py
ContextSuite context=TestTemplateUsage>:setup	`Error`	14.61	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	17.44	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	20.51	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	23.50	test_usage.py
test_01_webhook_deliveries	`Error`	4.99	test_webhook_delivery.py
ContextSuite context=TestVmAutoScaling>:setup	`Error`	0.00	test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host	`Error`	0.09	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	0.06	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	0.09	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.10	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	0.06	test_vm_deployment_planner.py
ContextSuite context=TestVMDeploymentPlanner>:teardown	`Error`	0.11	test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
ContextSuite context=TestKVMLiveMigration>:teardown	`Error`	0.02	test_vm_life_cycle.py
test_01_offline_migrate_VM_and_root_volume	`Error`	0.04	test_vm_life_cycle.py
test_02_offline_migrate_VM_with_two_data_disks	`Error`	0.04	test_vm_life_cycle.py
test_03_live_migrate_VM_with_two_data_disks	`Error`	0.03	test_vm_life_cycle.py
test_04_migrate_detached_volume	`Error`	0.03	test_vm_life_cycle.py
ContextSuite context=TestMigrateVMwithVolume>:teardown	`Error`	0.06	test_vm_life_cycle.py
test_01_vapps_vm_cycle	`Error`	0.25	test_vm_life_cycle.py
ContextSuite context=TestVAppsVM>:teardown	`Error`	0.27	test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	3.16	test_vm_life_cycle.py
test_01_unmanage_vm_cycle	`Error`	0.41	test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestUnmanageVM>:teardown	`Error`	0.45	test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestVMSchedule>:setup	`Error`	0.00	test_vm_schedule.py
test_change_service_offering_for_vm_with_snapshots	`Error`	0.04	test_vm_snapshots.py
ContextSuite context=TestChangeServiceOfferingForVmWithSnapshots>:teardown	`Error`	0.10	test_vm_snapshots.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	3.02	test_vm_snapshots.py
test_01_migrate_vm_strict_tags_success	`Error`	0.91	test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure	`Error`	0.76	test_vm_strict_host_tags.py
ContextSuite context=TestMigrateVMStrictTags>:teardown	`Error`	2.13	test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success	`Error`	1.00	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	`Error`	0.88	test_vm_strict_host_tags.py
ContextSuite context=TestRestoreVMStrictTags>:teardown	`Error`	1.61	test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success	`Error`	1.06	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Error`	1.58	test_vm_strict_host_tags.py
ContextSuite context=TestScaleVMStrictTags>:teardown	`Error`	2.39	test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags	`Error`	1.23	test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags	`Error`	1.27	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	`Error`	0.89	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	`Error`	0.99	test_vm_strict_host_tags.py
test_05_deploy_vm_on_specific_host_with_strict_tags_failure	`Failure`	0.79	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	0.91	test_vm_strict_host_tags.py
ContextSuite context=TestVMDeploymentPlannerStrictTags>:teardown	`Error`	1.75	test_vm_strict_host_tags.py
test_04_deploy_vnf_appliance	`Error`	20.79	test_vnf_templates.py
test_04_deploy_vnf_appliance	`Error`	20.80	test_vnf_templates.py
test_05_delete_vnf_template	`Error`	0.03	test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown	`Error`	0.07	test_vnf_templates.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	3.16	test_volumes.py
ContextSuite context=TestIpv6Vpc>:setup	`Error`	0.00	test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	3.11	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	2.92	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	2.96	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	2.85	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	3.07	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Error`	3.14	test_vpc_router_nics.py
test_02_VPC_default_routes	`Error`	2.86	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Error`	0.04	test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:teardown	`Error`	0.06	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Error`	0.04	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:teardown	`Error`	0.06	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	0.07	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:teardown	`Error`	0.09	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Error`	0.03	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:teardown	`Error`	0.05	test_vpc_vpn.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Error`	7.68	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	0.30	test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure	`Error`	3.43	test_host_maintenance.py

* Prevent addition of duplicate PF rules on scale up and no rules left behind on scale down (#32) * fix missing dependency injection * NSX: Fix concurrency issues on port forwarding rules deletion (#37) * Fix concurrency issues on port forwarding rules deletion * Refactor objectExists * Fix unit test * Fix test * Small fixes * CKS: Externalize control and worker node setup wait time and installation attempts (#38) * NSX: Add shared network support (#41) * NSX: Fix number of physical networks for Guest traffic checks and leftover rules on CKS cluster deletion (#45) * Fix pf rules removal on CKS cluster deletion * Fix check for number of physical networks for guest traffic * Fix unit test * fix logger * NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs * NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs * Remove unused string * fix logger * Update UDP active monitor to ICMP * Fix NPE on restarting VPC with additional public IPs * NSX / VPC: Reuse Source NAT IP from systemVM range on restarts * CKS: Public IP not found for VPC networks * Externalize retries and inverval for NSX segment deletion (#67) * remove unused import * remove duplicate imports * remove unused import * revert externalizing cks settings * fix test * Refactor log messages * Address comments * Fix issue caused due to forward merge: 90fe1d --------- Co-authored-by: Nicolas Vazquez <nicovazquez90@gmail.com> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Pearl1594 and others added 6 commits April 12, 2024 09:57

Prevent addition of duplicate PF rules on scale up and no rules left …

523620f

…behind on scale down (#32)

fix missing dependency injection

3579806

NSX: Fix concurrency issues on port forwarding rules deletion (#37)

f228c7a

* Fix concurrency issues on port forwarding rules deletion * Refactor objectExists * Fix unit test * Fix test * Small fixes

CKS: Externalize control and worker node setup wait time and installa…

a899648

…tion attempts (#38)

NSX: Add shared network support (#41)

968235a

NSX: Fix number of physical networks for Guest traffic checks and lef…

bcc8ff2

…tover rules on CKS cluster deletion (#45) * Fix pf rules removal on CKS cluster deletion * Fix check for number of physical networks for guest traffic * Fix unit test

Pearl1594 requested a review from nvazquez April 12, 2024 14:12

boring-cyborg bot added component:kubernetes component:networking component:UI labels Apr 12, 2024

Pearl1594 marked this pull request as draft April 12, 2024 14:14

fix logger

f44b8aa

nvazquez and others added 2 commits June 5, 2024 11:45

NSX: Handle CheckHealthCommand to avoid host disconnection and errors…

e79d771

… on APIs * NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs * Remove unused string

Merge branch 'main' of https://github.com/apache/cloudstack into nsx-…

4e57cc9

…integration-fixes

nvazquez approved these changes Jun 5, 2024

View reviewed changes

nvazquez added this to the 4.20.0.0 milestone Jun 5, 2024

Fix issue caused due to forward merge: 90fe1d

09159af

alexandremattioli approved these changes Sep 6, 2024

View reviewed changes

github-actions bot added the status:has-conflicts label Sep 6, 2024

Merge branch 'main' into nsx-integration-fixes

d1a6038

github-actions bot removed the status:has-conflicts label Sep 6, 2024

nvazquez merged commit f8d8a9c into main Sep 6, 2024

nvazquez deleted the nsx-integration-fixes branch September 6, 2024 19:57

winterhazel mentioned this pull request Feb 18, 2025

Fix comparison of Long objects to use primitives #9079

Closed

13 tasks

Conversation

Pearl1594 commented Apr 12, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov-commenter commented Apr 12, 2024 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Apr 12, 2024

Uh oh!

blueorangutan commented Apr 12, 2024

Uh oh!

blueorangutan commented Apr 12, 2024

Uh oh!

Pearl1594 commented Apr 12, 2024

Uh oh!

blueorangutan commented Apr 12, 2024

Uh oh!

blueorangutan commented Apr 12, 2024

Uh oh!

nvazquez commented Apr 12, 2024

Uh oh!

blueorangutan commented Apr 12, 2024

Uh oh!

blueorangutan commented Apr 13, 2024

Uh oh!

blueorangutan commented Apr 13, 2024

Uh oh!

blueorangutan commented Apr 13, 2024

Uh oh!

Pearl1594 commented Jun 5, 2024

Uh oh!

blueorangutan commented Jun 5, 2024

Uh oh!

nvazquez commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

Pearl1594 commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

alexandremattioli left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Sep 6, 2024

Uh oh!

github-actions bot commented Sep 6, 2024

Uh oh!

yadvr commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

sonarqubecloud bot commented Sep 6, 2024

Quality Gate failed

Uh oh!

DaanHoogland commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

yadvr commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

codecov-commenter commented Apr 12, 2024 •

edited by codecov bot

Loading