linstor: Improve copyPhysicalDisk performance#9417
Conversation
Tell qemu-img that we don't want to use a write cache (we are a block device) and also specify that we have zeroed devices in most cases.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #9417 +/- ##
===========================================
Coverage 12.25% 12.25%
+ Complexity 9319 9318 -1
===========================================
Files 4699 4699
Lines 414608 414627 +19
Branches 51002 53072 +2070
===========================================
+ Hits 50830 50833 +3
- Misses 357468 357483 +15
- Partials 6310 6311 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...age/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java
Show resolved
Hide resolved
|
Does this link to an existing issue @rp- ? |
No there is no issue for this. |
|
@blueorangutan package |
|
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10510 |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10617 |
|
@blueorangutan package |
|
Guess I need to add some 🍌 :) |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
monkey only reacts to last thing on his mind... |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10659 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-11085) |
|
[SF] Trillian test result (tid-11092)
|
* 4.18: linstor: Improve copyPhysicalDisk performance (#9417)
* 4.19: linstor: Improve copyPhysicalDisk performance (#9417)
Tell qemu-img that we don't want to use a write cache (we are a block device) and also specify that we have zeroed devices in most cases.
Tell qemu-img that we don't want to use a write cache (we are a block device) and also specify that we have zeroed devices in most cases.
* 4.18: linstor: Improve copyPhysicalDisk performance (apache#9417)
* 4.19: linstor: Improve copyPhysicalDisk performance (apache#9417)
Description
This will set better qemu-img convert options, depending on Linstors used storage pools.
Tell qemu-img that we don't want to use a write cache (we are a block device) and also specify that we have zeroed devices in most cases.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Copy new templates to primary storage on a Linstor cluster.
How did you try to break this feature and the system with this change?