[VMware] Disconnect/Detach config drive ISO (if exists) on stop VM by sureshanaparti · Pull Request #9468 · apache/cloudstack

sureshanaparti · 2024-07-30T06:39:56Z

Description

This PR disconnects/detachs config drive ISO (if exists) on stop VM in VMware. This is required for support some VM operations involving export OVF, on stopped VMs.

Root cause: Export OVF fails as there is no config drive file, it is removed when VM is stopped.

Fixes #9453

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested the start,stop,start VM operations and VM instance volume snapshots with config drive on VMware.

Before =>

After =>

2024-07-29T15:56:17,721 DEBUG [c.c.a.t.Request] (Work-Job-Executor-2:[ctx-bd90a732, job-217/job-218, ctx-bd64bbee]) (logid:fd80b170) Seq 1-234468655599976463: Executing:  { Cmd , MgmtId: 32989425697365, via: 1(10.0.34.85), Ver: v1, Flags: 100011, [{"com.cloud.agent.api.StopCommand":{"isProxy":"false","checkBeforeCleanup":"false","forceStop":"false","vlanToPersistenceMap":{"1727":"true"},"volumesToDisconnect":[],"vmName":"i-2-25-VM","executeInSequence":"false","wait":"0","bypassHostMaintenance":"false"}}] }
...
2024-07-29T15:56:21,045 INFO  [c.c.h.v.r.VmwareResource] (DirectAgent-14:[ctx-7ac38317, 10.0.34.85, job-217/job-218, cmd: StopCommand]) (logid:fd80b170) Disconnecting config drive at location: [c25a36f2689731989d17a452538ae70d] configdrive/i-2-25-VM.iso

2024-07-29T15:56:21,253 DEBUG [c.c.n.e.ConfigDriveNetworkElement] (Work-Job-Executor-2:[ctx-bd90a732, job-217/job-218, ctx-bd64bbee]) (logid:fd80b170) Deleting config drive ISO for vm: i-2-25-VM
2024-07-29T15:56:21,256 DEBUG [c.c.a.m.ClusteredAgentAttache] (Work-Job-Executor-2:[ctx-bd90a732, job-217/job-218, ctx-bd64bbee]) (logid:fd80b170) Seq 2-4190599453268246540: Routed from 32989425697365
2024-07-29T15:56:21,257 DEBUG [c.c.a.t.Request] (Work-Job-Executor-2:[ctx-bd90a732, job-217/job-218, ctx-bd64bbee]) (logid:fd80b170) Seq 3-4190599453268246540: Sending  { Cmd , MgmtId: 32989425697365, via: 3(s-2-VM), Ver: v1, Flags: 100011, [{"com.cloud.agent.api.HandleConfigDriveIsoCommand":{"isoFile":"configdrive/i-2-25-VM.iso","create":"false","destStore":{"com.cloud.agent.api.to.NfsTO":{"_url":"NFS://10.0.32.4/acs/secondary/pr9346-t10845-vmware-80/pr9346-t10845-vmware-80-sec1","_role":"Image"}},"useHostCacheOnUnsupportedPool":"false","preferHostCache":"false","wait":"0","bypassHostMaintenance":"false"}}] }
2024-07-29T15:56:21,321 DEBUG [c.c.a.t.Request] (AgentManager-Handler-8:[]) (logid:) Seq 3-4190599453268246540: Processing:  { Ans: , MgmtId: 32989425697365, via: 3, Ver: v1, Flags: 10, [{"com.cloud.agent.api.HandleConfigDriveIsoAnswer":{"result":"true","wait":"0","bypassHostMaintenance":"false"}}] }
2024-07-29T15:56:21,321 DEBUG [c.c.a.t.Request] (Work-Job-Executor-2:[ctx-bd90a732, job-217/job-218, ctx-bd64bbee]) (logid:fd80b170) Seq 3-4190599453268246540: Received:  { Ans: , MgmtId: 32989425697365, via: 3(s-2-VM), Ver: v1, Flags: 10, { HandleConfigDriveIsoAnswer } }
...
2024-07-29T15:56:21,213 DEBUG [c.c.a.t.Request] (DirectAgent-14:[ctx-7ac38317]) (logid:fd80b170) Seq 1-234468655599976463: Processing:  { Ans: , MgmtId: 32989425697365, via: 1(10.0.34.85), Ver: v1, Flags: 10, [{"com.cloud.agent.api.StopAnswer":{"result":"true","details":"Stop VM i-2-25-VM Succeed","wait":"0","bypassHostMaintenance":"false"}}] }
2024-07-29T15:56:21,213 DEBUG [c.c.a.t.Request] (Work-Job-Executor-2:[ctx-bd90a732, job-217/job-218, ctx-bd64bbee]) (logid:fd80b170) Seq 1-234468655599976463: Received:  { Ans: , MgmtId: 32989425697365, via: 1(10.0.34.85), Ver: v1, Flags: 10, { StopAnswer } }

How did you try to break this feature and the system with this change?

sureshanaparti · 2024-07-30T06:41:37Z

@blueorangutan package

blueorangutan · 2024-07-30T06:42:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-07-30T06:48:01Z

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (f0ba905) to head (ea6fcd1).
Report is 20 commits behind head on 4.19.

Files	Patch %	Lines
...oud/hypervisor/vmware/resource/VmwareResource.java	0.00%	20 Missing ⚠️
...m/cloud/hypervisor/vmware/mo/VirtualMachineMO.java	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19    #9468    +/-   ##
==========================================
  Coverage     15.07%   15.08%            
- Complexity    11168    11179    +11     
==========================================
  Files          5406     5406            
  Lines        472795   472940   +145     
  Branches      57834    58539   +705     
==========================================
+ Hits          71282    71328    +46     
- Misses       393585   393671    +86     
- Partials       7928     7941    +13

Flag	Coverage Δ
uitests	`4.30% <ø> (ø)`
unittests	`15.79% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weizhouapache

code lgtm

not tested yet

blueorangutan · 2024-07-30T07:44:51Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10513

weizhouapache · 2024-07-30T08:42:11Z

@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2024-07-30T08:44:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2024-07-30T21:26:58Z

[SF] Trillian test result (tid-10995)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 43918 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9468-t10995-vmware-70u3.zip
Smoke tests completed. 105 look OK, 11 have errors, 16 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_01_restore_vm	`Error`	3606.32	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	6.79	test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown	`Error`	15.20	test_restore_vm.py
test_01_prepare_and_cancel_shutdown	`Error`	2.57	test_safe_shutdown.py
test_02_trigger_shutdown	`Failure`	301.43	test_safe_shutdown.py
test_01_scale_vm	`Error`	0.02	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	`Error`	0.02	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	`Error`	0.02	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	2.71	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	2.71	test_scale_vm.py
test_05_scale_vm_dont_allow_disk_offering_change	`Error`	0.08	test_scale_vm.py
ContextSuite context=TestScaleVm>:teardown	`Error`	0.22	test_scale_vm.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	2.80	test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
test_05_stop_ssvm	`Error`	0.14	test_ssvm.py
test_06_stop_cpvm	`Error`	0.13	test_ssvm.py
test_07_reboot_ssvm	`Error`	0.13	test_ssvm.py
test_08_reboot_cpvm	`Error`	0.12	test_ssvm.py
test_09_reboot_ssvm_forced	`Error`	0.12	test_ssvm.py
test_10_reboot_cpvm_forced	`Error`	0.12	test_ssvm.py
test_11_destroy_ssvm	`Error`	0.09	test_ssvm.py
test_12_destroy_cpvm	`Error`	0.09	test_ssvm.py
test_01_import_storage_policies	`Error`	4.86	test_storage_policy.py
ContextSuite context=TestVMWareStoragePolicies>:teardown	`Error`	4.89	test_storage_policy.py
ContextSuite context=TestCopyAndDeleteTemplatesAcrossZones>:setup	`Error`	0.00	test_templates.py
ContextSuite context=TestCreateTemplate>:setup	`Error`	0.00	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	5.65	test_templates.py
test_01_positive_tests_usage	`Failure`	2.63	test_usage_events.py
test_01_positive_tests_usage	`Error`	2.63	test_usage_events.py
all_test_usage	`Skipped`	---	test_usage.py
all_test_vm_autoscaling	`Skipped`	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	`Skipped`	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	`Skipped`	---	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	`Skipped`	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_schedule	`Skipped`	---	test_vm_schedule.py
all_test_vm_snapshot_kvm	`Skipped`	---	test_vm_snapshot_kvm.py
all_test_vm_snapshots	`Skipped`	---	test_vm_snapshots.py
all_test_vnf_templates	`Skipped`	---	test_vnf_templates.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

yadvr · 2024-08-08T06:25:39Z

@blueorangutan package

blueorangutan · 2024-08-08T06:26:04Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-08T07:33:07Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10595

sureshanaparti · 2024-08-09T10:44:08Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2024-08-09T10:46:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2024-08-09T22:01:29Z

[SF] Trillian test result (tid-11049)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 38428 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9468-t11049-vmware-70u3.zip
Smoke tests completed. 107 look OK, 10 have errors, 16 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_restore_vm	`Error`	3615.28	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	7.78	test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown	`Error`	14.10	test_restore_vm.py
test_01_prepare_and_cancel_shutdown	`Error`	2.48	test_safe_shutdown.py
test_02_trigger_shutdown	`Failure`	301.28	test_safe_shutdown.py
test_01_scale_vm	`Error`	0.02	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	`Error`	0.02	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	`Error`	0.02	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	2.95	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	2.95	test_scale_vm.py
test_05_scale_vm_dont_allow_disk_offering_change	`Error`	0.09	test_scale_vm.py
ContextSuite context=TestScaleVm>:teardown	`Error`	0.22	test_scale_vm.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	2.83	test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
test_05_stop_ssvm	`Error`	0.12	test_ssvm.py
test_06_stop_cpvm	`Error`	0.12	test_ssvm.py
test_07_reboot_ssvm	`Error`	0.11	test_ssvm.py
test_08_reboot_cpvm	`Error`	0.12	test_ssvm.py
test_09_reboot_ssvm_forced	`Error`	0.12	test_ssvm.py
test_10_reboot_cpvm_forced	`Error`	0.11	test_ssvm.py
test_11_destroy_ssvm	`Error`	0.10	test_ssvm.py
test_12_destroy_cpvm	`Error`	0.10	test_ssvm.py
test_01_import_storage_policies	`Error`	4.86	test_storage_policy.py
ContextSuite context=TestVMWareStoragePolicies>:teardown	`Error`	4.91	test_storage_policy.py
ContextSuite context=TestCopyAndDeleteTemplatesAcrossZones>:setup	`Error`	0.00	test_templates.py
ContextSuite context=TestCreateTemplate>:setup	`Error`	0.00	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	5.82	test_templates.py
test_01_positive_tests_usage	`Failure`	2.74	test_usage_events.py
test_01_positive_tests_usage	`Error`	2.74	test_usage_events.py
all_test_usage	`Skipped`	---	test_usage.py
all_test_vm_autoscaling	`Skipped`	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	`Skipped`	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	`Skipped`	---	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	`Skipped`	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_schedule	`Skipped`	---	test_vm_schedule.py
all_test_vm_snapshot_kvm	`Skipped`	---	test_vm_snapshot_kvm.py
all_test_vm_snapshots	`Skipped`	---	test_vm_snapshots.py
all_test_vnf_templates	`Skipped`	---	test_vnf_templates.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

sureshanaparti · 2024-08-22T06:55:31Z

@blueorangutan package

blueorangutan · 2024-08-22T06:56:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-22T07:56:25Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10742

shwstppr

Logic looks good. Minor comments wrt refactoring

vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

vladimirpetrov

LGTM based on manual testing using VMWare 8.0u1.

sureshanaparti · 2024-08-26T05:59:30Z

@blueorangutan package

blueorangutan · 2024-08-26T06:00:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-26T06:47:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10797

sureshanaparti · 2024-08-26T07:40:38Z

@blueorangutan test ol8 vmware-70u3

blueorangutan · 2024-08-26T07:42:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2024-08-26T21:49:35Z

[SF] Trillian test result (tid-11174)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48515 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9468-t11174-vmware-70u3.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…pache#9468)

[VMware] Disconnect/Detach config drive ISO (if exists) on stop VM

6bf87be

boring-cyborg bot added the component:vmware label Jul 30, 2024

sureshanaparti requested review from nvazquez, shwstppr and weizhouapache July 30, 2024 06:40

sureshanaparti linked an issue Jul 30, 2024 that may be closed by this pull request

ConfigDrive ISO is not detached from stopped on VMware #9453

Closed

weizhouapache approved these changes Jul 30, 2024

View reviewed changes

yadvr added this to the 4.19.2.0 milestone Aug 8, 2024

yadvr closed this Aug 8, 2024

yadvr reopened this Aug 8, 2024

shwstppr approved these changes Aug 22, 2024

View reviewed changes

vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java Outdated Show resolved Hide resolved

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java Outdated Show resolved Hide resolved

sureshanaparti added the status:needs-testing label Aug 22, 2024

vladimirpetrov self-assigned this Aug 22, 2024

vladimirpetrov approved these changes Aug 23, 2024

View reviewed changes

vladimirpetrov removed the status:needs-testing label Aug 23, 2024

addressed review comments

ea6fcd1

DaanHoogland merged commit 6c04923 into apache:4.19 Aug 27, 2024

DaanHoogland deleted the vmware-detach-config-drive-iso-on-stop-vm branch August 27, 2024 09:11

DaanHoogland mentioned this pull request Aug 27, 2024

ConfigDrive ISO is not detached from stopped on VMware #9453

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 30, 2024

[VMware] Disconnect/Detach config drive ISO (if exists) on stop VM (a…

e22b17c

…pache#9468)

Conversation

sureshanaparti commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Jul 30, 2024

Uh oh!

blueorangutan commented Jul 30, 2024

Uh oh!

codecov bot commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jul 30, 2024

Uh oh!

weizhouapache commented Jul 30, 2024

Uh oh!

blueorangutan commented Jul 30, 2024

Uh oh!

blueorangutan commented Jul 30, 2024

Uh oh!

yadvr commented Aug 8, 2024

Uh oh!

blueorangutan commented Aug 8, 2024

Uh oh!

blueorangutan commented Aug 8, 2024

Uh oh!

sureshanaparti commented Aug 9, 2024

Uh oh!

blueorangutan commented Aug 9, 2024

Uh oh!

blueorangutan commented Aug 9, 2024

Uh oh!

sureshanaparti commented Aug 22, 2024

Uh oh!

blueorangutan commented Aug 22, 2024

Uh oh!

blueorangutan commented Aug 22, 2024

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vladimirpetrov left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Aug 26, 2024

Uh oh!

blueorangutan commented Aug 26, 2024

Uh oh!

blueorangutan commented Aug 26, 2024

Uh oh!

sureshanaparti commented Aug 26, 2024

Uh oh!

blueorangutan commented Aug 26, 2024

Uh oh!

blueorangutan commented Aug 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sureshanaparti commented Jul 30, 2024 •

edited

Loading

codecov bot commented Jul 30, 2024 •

edited

Loading