Fix Template and ISO upload events#9545
Conversation
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
| String eventResourceId = template.getUuid(); | ||
| CallContext.current().setEventDetails(String.format("%s Id: %s", eventType, eventResourceId)); | ||
| CallContext.current().putContextParameter(eventType.equals("Iso") ? eventType : VirtualMachineTemplate.class, eventResourceId); | ||
| if (template.getFormat().equals(ImageFormat.ISO)) { |
There was a problem hiding this comment.
Is this required to be specific to only ISOs?
There was a problem hiding this comment.
Yes, otherwise the event resource was not being obtained. For templates it wasn't needed as the event resource was properly set on the event
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #9545 +/- ##
===========================================
Coverage 12.27% 12.27%
- Complexity 9334 9337 +3
===========================================
Files 4699 4699
Lines 414650 414657 +7
Branches 51963 50963 -1000
===========================================
+ Hits 50880 50897 +17
+ Misses 357446 357434 -12
- Partials 6324 6326 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10697 |
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-11102)
|
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM
The events are present when a template and a iso is uploaded
Description
This PR adds the missing events when uploading templates and ISOs.
Fixes: #8052
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested uploading templates, ISOs and volumes for comparisson
How did you try to break this feature and the system with this change?