Skip to content

[UI] Add project toggle for buckets#9589

Merged
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:project-toggle-for-buckets
Aug 26, 2024
Merged

[UI] Add project toggle for buckets#9589
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:project-toggle-for-buckets

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Aug 26, 2024 •
edited
Loading

Description

This PR adds project toggle for buckets, in UI.

Fixes #8422

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually verified project toogle in buckets section.

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Aug 26, 2024

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Aug 26, 2024

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (0597def) to head (70a1b87).
Report is 3 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff             @@
##               4.19    #9589    +/-   ##
==========================================
  Coverage     15.08%   15.08%            
- Complexity    11184    11187     +3     
==========================================
  Files          5406     5406            
  Lines        472915   472915            
  Branches      60040    60480   +440     
==========================================
+ Hits          71345    71352     +7     
+ Misses       393626   393616    -10     
- Partials       7944     7947     +3
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

blueorangutan commented Aug 26, 2024

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9589 (QA-JID-432)

@sureshanaparti sureshanaparti linked an issue Aug 26, 2024 that may be closed by this pull request
The Project toggle should be present for Buckets #8422
Closed
@kiranchavala
Copy link
Member

kiranchavala commented Aug 26, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 26, 2024

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Aug 26, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10806

DaanHoogland
DaanHoogland approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, toggle present in UI, toggling in QA triggers the right calls:
image

kiranchavala
kiranchavala approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Project created object store buckets are visible

Before fix

beforefixbucket

After fix

Screenshot 2024-08-26 at 6 37 50 PM

@sureshanaparti sureshanaparti marked this pull request as ready for review August 26, 2024 13:09
@DaanHoogland DaanHoogland merged commit 9148701 into apache:4.19 Aug 26, 2024
@DaanHoogland DaanHoogland deleted the project-toggle-for-buckets branch August 26, 2024 13:14
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 30, 2024
@sureshanaparti @dhslove
[UI] Add project toggle for buckets (apache#9589)
fe8c000
@DaanHoogland DaanHoogland added this to the 4.19.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

@kiranchavala kiranchavala

Labels

component:UI

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

The Project toggle should be present for Buckets

4 participants

@sureshanaparti @blueorangutan @kiranchavala @DaanHoogland