Skip to content

propagate sort order through retrieval sequence#9624

Merged
DaanHoogland merged 3 commits intoapache:4.19from
shapeblue:ghi9595-sorting
Sep 5, 2024
Merged

propagate sort order through retrieval sequence#9624
DaanHoogland merged 3 commits intoapache:4.19from
shapeblue:ghi9595-sorting

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Sep 2, 2024 •
edited
Loading

Description

This PR...

Fixes: #9595

Note that is only fixes the regression reported in #9595, not enhancing it or fixing any ordering bugs that were already present before 4.19, except that the renumbering now only takes place within the page displayed.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

both with API (cmk) and UI

@github-actions
Copy link

github-actions bot commented Sep 2, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland DaanHoogland changed the base branch from main to 4.19 September 2, 2024 12:17
@codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (0204cb7) to head (54929b3).
Report is 12 commits behind head on 4.19.

Files with missing lines Patch % Lines
...loud/api/query/dao/ServiceOfferingJoinDaoImpl.java 0.00% 8 Missing ⚠️
...m/cloud/api/query/dao/DiskOfferingJoinDaoImpl.java 0.00% 4 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##               4.19    #9624     +/-   ##
===========================================
  Coverage     15.08%   15.08%             
- Complexity    11185    11189      +4     
===========================================
  Files          5406     5406             
  Lines        473123   473184     +61     
  Branches      58163    61053   +2890     
===========================================
+ Hits          71371    71382     +11     
- Misses       393810   393856     +46     
- Partials       7942     7946      +4
Flag Coverage Δ
uitests 4.30% <ø> (-0.01%) ⬇️
unittests 15.80% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vishesh92
vishesh92 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland marked this pull request as ready for review September 4, 2024 13:11
@DaanHoogland DaanHoogland requested a review from yadvr September 4, 2024 13:14
@DaanHoogland DaanHoogland mentioned this pull request Sep 4, 2024
Closed
@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Sep 4, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Sep 4, 2024

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Sep 4, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10967

@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Sep 4, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Sep 4, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

yadvr
yadvr approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - didn't test it though

@yadvr yadvr added this to the 4.19.2.0 milestone Sep 5, 2024
vishesh92
vishesh92 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. Tested basic workflow and it's working as expected.

@DaanHoogland DaanHoogland merged commit 0fae0c0 into apache:4.19 Sep 5, 2024
@DaanHoogland DaanHoogland deleted the ghi9595-sorting branch September 5, 2024 07:37
@blueorangutan
Copy link

blueorangutan commented Sep 5, 2024

[SF] Trillian test result (tid-11349)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51059 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9624-t11349-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 6, 2024
@DaanHoogland @dhslove
propagate sort order through retrieval sequence (apache#9624)
ef3200d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

Assignees

No one assigned

Labels

component:storage component:UI type:regression

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

UI sorting of elements not working on some views

4 participants

@DaanHoogland @blueorangutan @yadvr @vishesh92