CLOUDSTACK-8935 - Cannot remove [r]VPC networks due to RTNETLINK error#967
CLOUDSTACK-8935 - Cannot remove [r]VPC networks due to RTNETLINK error#967asfgit merged 5 commits intoapache:masterfrom artificially-ai:fix/cleanup-CLOUDSTACK-8935
Conversation
- This will fix the cleanup problems.
|
Ping @remibergsma @wido @borisroman @miguelaferreira @karuturi @bhaisaab @DaanHoogland Additional non-hardware required tests still running, but I would like to share the results of the ones which require hardware. Test Environment
Tests Results (hardware_required = true) Cheers, |
|
Hi all, Please keep it on hold: I tested the network deletion manually before the component/test_vpc_offerings.py was completed. Deleting the network manually worked fine, but I still have the exception with the tests. Perhaps the test needs some tuning. I will have a look into it. Cheers, |
|
@wilderrodrigues ping me when you want me to run some tests! |
|
@wilderrodrigues i'm on it when it's ready! |
|
I'm running the new test now. Once done, I will push it and you can proceed with testing the PR. Cheers, |
|
Ping @remibergsma @miguelaferreira @borisroman @DaanHoogland It's now fixed for real! I will run more tests and have an extensive report here soon. Cheers, |
|
Cool. Will run the build again with this PR |
|
Ping @remibergsma @miguelaferreira @DaanHoogland @borisroman More tests:
Cheers, |
|
Let's get this merged: Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS === Ran 21 tests in 10657.776s OK Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS === Ran 40 tests in 8310.689s OK |
|
LGTM, based on a set of tests that I run on this branch: Result: And: Result: Awesome work @wilderrodrigues ! Now the 3 tests that were failing all the time pass :-) Really happy about that! Thank you 👍 |
CLOUDSTACK-8935 - Cannot remove [r]VPC networks due to RTNETLINK errorThis PR fixes the "sequence item 0: expected string, NoneType found" error found in the CsDhcp.py file when attempting to remo a network from a VPC. * pr/967: CLOUDSTACK-8935 - Filter the DNS list because it might contain 1 None entry which breaks the code. CLOUDSTACK-8935 - Clean up network resources in the right order CLOUDSTACK-8935 - Do not retry 60 times when we expect the SSH to fail CLOUDSTACK-8935 - Check if the key is available in the dictionary CLOUDSTACK-8935 - Add a check to avoid exception related to None value Signed-off-by: Remi Bergsma <github@remi.nl>
This PR fixes the "sequence item 0: expected string, NoneType found" error found in the CsDhcp.py file when attempting to remo a network from a VPC.