Skip to content

Revert "storage: fix private templates are not copied to new image store (#9206)"#9839

Merged
JoaoJandre merged 1 commit intoapache:4.19from
weizhouapache:4.19-revert-pr9206
Nov 13, 2024
Merged

Revert "storage: fix private templates are not copied to new image store (#9206)"#9839
JoaoJandre merged 1 commit intoapache:4.19from
weizhouapache:4.19-revert-pr9206

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Oct 22, 2024 •
edited
Loading

Description

This reverts commit e06f80e.

I have discussed with @NuxRo @rajujith @alexandremattioli , it seems it is expected that private template has only 1 copy on the secondary storages.

we all agreed that it should be improved as the template with 1 copy becomes unavailable if the secondary storage is removed.
ideally there is a global setting to specify the minimum number of copies on secondary storages.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.19.2.0 milestone Oct 22, 2024
@codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (175eed2) to head (0319275).
Report is 24 commits behind head on 4.19.

Files with missing lines Patch % Lines
.../cloudstack/storage/image/TemplateServiceImpl.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9839      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
+ Complexity    11203    11202       -1     
============================================
  Files          5404     5404              
  Lines        473423   473426       +3     
  Branches      59987    60080      +93     
============================================
- Hits          71429    71426       -3     
- Misses       394044   394050       +6     
  Partials       7950     7950
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.80% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajujith
Copy link

rajujith commented Oct 23, 2024

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 23, 2024

@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 23, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11414

rajujith
rajujith approved these changes Oct 23, 2024
View reviewed changes
Copy link

@rajujith rajujith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
tested and working as expected now.

DaanHoogland
DaanHoogland approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, functionality seems off a bit. (not a -1!)

@yadvr
Copy link
Member

yadvr commented Nov 7, 2024

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 7, 2024

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Nov 7, 2024

[SF] Trillian test result (tid-11760)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48262 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9839-t11760-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@JoaoJandre JoaoJandre merged commit adbf370 into apache:4.19 Nov 13, 2024
@DaanHoogland DaanHoogland deleted the 4.19-revert-pr9206 branch November 13, 2024 13:47
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 20, 2024
@weizhouapache @dhslove
Revert "storage: fix private templates are not copied to new image st…
cdec6b8 
…ore (apache#9206)" (apache#9839)

This reverts commit e06f80e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@rajujith rajujith rajujith approved these changes

@NuxRo NuxRo Awaiting requested review from NuxRo

@JoaoJandre JoaoJandre Awaiting requested review from JoaoJandre

Assignees

No one assigned

Labels

component:storage type:bug

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

6 participants

@weizhouapache @rajujith @blueorangutan @yadvr @DaanHoogland @JoaoJandre