feat: support type cast in SchemaAdapter#6404
Merged
tustvold merged 4 commits intoapache:mainfrom May 23, 2023
Merged
Conversation
tustvold
approved these changes
May 22, 2023
Contributor
tustvold
left a comment
There was a problem hiding this comment.
This is really nice, thank you. Left some minor comments, but this is also good to go as is
Contributor
Author
Thank you for taking the time to review my PR 🙏. I have updated the code. Please take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6381
Rationale for this change
What changes are included in this PR?
introduces a
map_schemamethod that maps the file schema to the table schema, and aSchemaMappingstructure to hold the mapping and necessary type conversions.Are these changes tested?
Yes
Are there any user-facing changes?