[improve][broker] PIP-380: Support-setting-up-specific-namespaces-to-skipping-the-load-shedding#23549
Merged
BewareMyPower merged 3 commits intoapache:masterfrom Jun 10, 2025
Conversation
heesung-sohn
approved these changes
Nov 14, 2024
Contributor
heesung-sohn
left a comment
There was a problem hiding this comment.
Left minor comments. otherwise LGTM.
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java
Outdated
Show resolved
Hide resolved
...r-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
Contributor
|
btw, we probably want to add this bundle load data filtering logic here as well, |
Member
Author
|
@heesung-sn Updated. PTAL again. |
Contributor
|
LGTM |
f1729e0 to
bb1ab6c
Compare
codelipenghui
approved these changes
May 28, 2025
bb1ab6c to
25e2580
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23549 +/- ##
============================================
+ Coverage 73.57% 74.28% +0.70%
+ Complexity 32624 32324 -300
============================================
Files 1877 1868 -9
Lines 139502 145319 +5817
Branches 15299 16623 +1324
============================================
+ Hits 102638 107943 +5305
+ Misses 28908 28833 -75
- Partials 7956 8543 +587
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…skipping-the-load-shedding (apache#23549)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…skipping-the-load-shedding (apache#23549)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIP: PIP-380 #23304
Motivation
#23304
Modifications
Add a new configuration
loadBalancerSheddingExcludedNamespacesto allow disabling the load balancer shedding for specific namespaces.Documentation
docdoc-requireddoc-not-neededdoc-complete