fix(build): fix variable in build script#237
Merged
ShannonDing merged 1 commit intoapache:masterfrom Feb 11, 2020
Merged
Conversation
ShannonDing
approved these changes
Feb 11, 2020
Member
|
hello, @gitoso , welcome to apache rocketmq community, the GSoC 2020 will be starting soon, could you please send an email to me and I will send you some information about it if you are interested in it? |
Contributor
Author
Thank you, I sent a message to the email in your github profile ^^ |
Member
|
@gitoso here are some preliminary proposal(apache/rocketmq-externals#512). if you are interested, we would like to help you to complete these in the nearing GSoC 2020. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The line
unzip -o ${fname_libevent} >unziplibevent.txt 2>&creates the fileunziplibevent.txtin the directory. So when setting the directory name withlibevent_dir=$(ls | grep libevent | grep .*[^zip]$)the variable will have the name of two files andcd ${libevent_dir}will promptcd: Too many arguments.Brief changelog
Just adding the .txt extension to the exclusion list during the grep command is enough to solve the problem. In the end we have
libevent_dir=$(ls | grep libevent | grep .*[^zip^txt]$).