Skip to content

Conversation

@neutrinoceros
Copy link
Contributor

Description

Fixes #18126

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros marked this pull request as ready for review May 28, 2025 08:04
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense to just filter out the warning - eventually, _UnionGenericAlias will just disappear anyway and typical usage of itersubclasses will not encounter this.

@mhvk mhvk merged commit 863b40e into astropy:main May 28, 2025
40 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 28, 2025
…ation warning from a private, builtin class (`_UnionGenericAlias`)
@neutrinoceros neutrinoceros deleted the io.fits/tst/cp314/filter_depr_warning branch May 28, 2025 11:51
pllim added a commit that referenced this pull request May 29, 2025
…182-on-v7.1.x

Backport PR #18182 on branch v7.1.x (TST: globally filter out a harmless deprecation warning from a private, builtin class (`_UnionGenericAlias`))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC/TST: itersubclasses' doctest is broken on CPython 3.14.0b1

2 participants