Replace struct update_fee_delta with lambda#24625
Merged
fanquake merged 2 commits intobitcoin:masterfrom Mar 24, 2022
Hidden character warning
The head ref may contain hidden characters: "2203-refactor-fee-delta-\ud83d\udd36"
Merged
Conversation
Member
|
Concept ACK. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
hebasto
approved these changes
Mar 21, 2022
Member
hebasto
left a comment
There was a problem hiding this comment.
ACK fa131d3630bb8da6816e50a9a37c0ed4ad4ee33c, I have reviewed the code.
fa131d3 to
fa84a49
Compare
hebasto
approved these changes
Mar 21, 2022
promag
reviewed
Mar 21, 2022
Contributor
Member
Author
|
I didn't touch the other structs, as they take multiple arguments. I think before touching them, we should ideally decide whether to use designated initializers or clang-tidy named arguments. |
Member
|
@glozow want to review? |
Member
|
Concept ACK, haven't reviewed code |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 2, 2022
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 23, 2022
Summary: This is a backport of [[bitcoin/bitcoin#24625 | core#24625]] The second commit is already done in Bitcoin ABC. Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D12591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same was done for another struct in e177fca.
Also, change type of feeDelta from int64_t to CAmount.