negotiateContext: Use current key as fallback if Subkey is not sent#86
Merged
bodgit merged 1 commit intobodgit:masterfrom Oct 29, 2022
Merged
negotiateContext: Use current key as fallback if Subkey is not sent#86bodgit merged 1 commit intobodgit:masterfrom
bodgit merged 1 commit intobodgit:masterfrom
Conversation
Owner
|
LGTM, I didn't spot this in the RFC although they are a bit heavy reading. I want to update the versions of Go used in the tests so it's 1.19 and 1.18 and then I'll cut a new release with this fix in, which should hopefully be picked up by the external-dns project automatically. |
Owner
|
v1.2.1 is released with your fix, thanks again for your contribution. |
Author
|
Great, thank you very much for the fast merge and release!
30.10.2022 00:09:16 Matt Dainty ***@***.***>:
… v1.2.1 is released with your fix, thanks again for your contribution.
—
Reply to this email directly, view it on GitHub[#86 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AB563QXKWAHGZR7JJX6U73TWFWOATANCNFSM6AAAAAARQZSP2A].
You are receiving this because you authored the thread.[Verfolgungsbild][https://github.com/notifications/beacon/AB563QWJIHPXNCW7ACRE24DWFWOATA5CNFSM6AAAAAARQZSP2CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSNH5PCG.gif]
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to use bodgit/tsig (or rather kubernetes-sigs/external-dns, which uses miekg/dns, which uses bodgit/tsig) to perform dynamic DNS updates on a Samba Domain Controller (with a bind DNS backend).
This failed with "
unknown or unsupported EType: 0", because theEncAPRepPartof the TKEY reply does not contain aSubkey.According to https://www.rfc-editor.org/rfc/rfc4120#section-5.5.2
subkeyis an optional field. If it is not sent, the session key from the ticket should be used.With this change, updating DNS records in samba works.