Conversation
Should mean `config.Load()` is never called with an empty string.
austinvalle
reviewed
Feb 10, 2023
austinvalle
left a comment
There was a problem hiding this comment.
Hey @bodgit 👋🏻 !
I recreated the original issue that was raised in terraform-provider-dns and ran it with your library changes.
v1.2.1
=== RUN TestAccDnsTXTRecordSet_Basic
resource_dns_txt_record_set_test.go:47: Step 1/6 error: Error running apply: exit status 1
Error: Error updating DNS record: Error negotiating GSS context: configuration file could not be opened: open : no such file or directory
with dns_txt_record_set.foo,
on terraform_plugin_test.tf line 3, in resource "dns_txt_record_set" "foo":
3: resource "dns_txt_record_set" "foo" {
#92 - a2d9455fba66a2347cbb8865b182b7cc957819bc
=== RUN TestAccDnsTXTRecordSet_Basic
resource_dns_txt_record_set_test.go:47: Step 1/6 error: Error running apply: exit status 1
Error: Error updating DNS record: Error negotiating GSS context: 1 error occurred:
* stat /etc/krb5.conf: no such file or directory
with dns_txt_record_set.foo,
on terraform_plugin_test.tf line 3, in resource "dns_txt_record_set" "foo":
3: resource "dns_txt_record_set" "foo" {
Overall this PR looks great! I did have one non-critical note that I left.
Thanks again for taking a look 👋🏻
Also wrap `os.Stat()` error when checking env value.
austinvalle
approved these changes
Feb 13, 2023
austinvalle
left a comment
There was a problem hiding this comment.
Here is the result with 45db94c:
=== RUN TestAccDnsTXTRecordSet_Basic
resource_dns_txt_record_set_test.go:47: Step 1/6 error: Error running apply: exit status 1
Error: Error updating DNS record: Error negotiating GSS context: 2 errors occurred:
* KRB5_CONFIG: not found
* stat /etc/krb5.conf: no such file or directory
with dns_txt_record_set.foo,
on terraform_plugin_test.tf line 3, in resource "dns_txt_record_set" "foo":
3: resource "dns_txt_record_set" "foo" {
Looks great! 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should mean
config.Load()is never called with an empty string.