Use json-iterator/go for all JSON operations#556
Merged
boyter merged 1 commit intoboyter:masterfrom Nov 11, 2024
Merged
Conversation
c564270 to
fbc344c
Compare
Owner
|
Reduction of the binary size is the main reason I like this. The reason I removed it was due to the speed being negligible for everything I tried. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we have two JSON libraries in the code base: "encoding/json" and "github.com/json-iterator/go". Use one of them is completely enough.
The "json-iterator/go" is faster than the stdlib and uses less memory. So we choose the fast one for all JSON operations.
It also reduces the binary file size. For an example on Linux AMD64 with Go1.22.7, the binary file change is
8988568 -> 8811060 bytes, more than 150 kib was reduced.