Skip to content

Comments

Exceptions: support creating a Ref::null for an exception type.#11531

Merged
cfallin merged 1 commit intobytecodealliance:mainfrom
cfallin:exn-top-type-fuzzing
Aug 25, 2025
Merged

Exceptions: support creating a Ref::null for an exception type.#11531
cfallin merged 1 commit intobytecodealliance:mainfrom
cfallin:exn-top-type-fuzzing

Conversation

@cfallin
Copy link
Member

@cfallin cfallin commented Aug 25, 2025

Missed adding this case to the match arms. Found via OSS-Fuzz.

Fixes #11529.

Missed adding this case to the match arms. Found via OSS-Fuzz.

Fixes bytecodealliance#11529.
@cfallin cfallin requested a review from a team as a code owner August 25, 2025 16:14
@cfallin cfallin requested review from dicej and removed request for a team August 25, 2025 16:14
@dicej dicej enabled auto-merge August 25, 2025 16:33
@dicej dicej added this pull request to the merge queue Aug 25, 2025
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Aug 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 25, 2025
@cfallin cfallin added this pull request to the merge queue Aug 25, 2025
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably time we added a wasmtime::HeapTopType so that these kinds of matches can be exhaustive, there are a handful of places where we do this and we probably haven't caught all of them...

Merged via the queue into bytecodealliance:main with commit 1ee4829 Aug 25, 2025
86 of 88 checks passed
@cfallin cfallin deleted the exn-top-type-fuzzing branch August 25, 2025 19:10
bongjunj pushed a commit to prosyslab/wasmtime that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:api Related to the API of the `wasmtime` crate itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime panic getting top type for exceptions

3 participants