Skip to content

Fix issue described in #815#816

Merged
calavera merged 2 commits intocargo-lambda:mainfrom
bassmanitram:fix/apis-only-default-function
Mar 12, 2025
Merged

Fix issue described in #815#816
calavera merged 2 commits intocargo-lambda:mainfrom
bassmanitram:fix/apis-only-default-function

Conversation

@bassmanitram
Copy link
Contributor

@bassmanitram bassmanitram commented Mar 12, 2025

#815

Add only-lambda-apis flag to RuntimeState and to is_default_function_enabled assessment

This allows the default Lambda function functionality to work for --only-lambda-apis

…ed assessment

No tests yet, but this makes the use case described in the associated issue
work as expected.
@bassmanitram bassmanitram marked this pull request as draft March 12, 2025 09:13
@bassmanitram
Copy link
Contributor Author

@calavera So - this seems ridiculously simple, so I'm sure I'm missing something, but the #815 use case works perfectly with this.

I see an opportunity for the future - that lambda functions that hook up to the watcher can dynamically be added to the function list and thus be invoked by name - but, then again, doesn't that just make --only-lambda-apis essentially a full-blooded local Lambda service :) ?

@bassmanitram bassmanitram changed the title Add only-lambda-apis to RuntimeState... Fix #815 Mar 12, 2025
@bassmanitram bassmanitram changed the title Fix #815 Fix issue described in #815 Mar 12, 2025
Copy link
Collaborator

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense at first glance. Yes, I believe this should be as simple as this change.

@bassmanitram bassmanitram marked this pull request as ready for review March 12, 2025 17:54
@bassmanitram
Copy link
Contributor Author

This makes sense at first glance. Yes, I believe this should be as simple as this change.

I have reverted the version number and marked the PR as ready for review - over to you, sir!

Copy link
Collaborator

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@calavera calavera merged commit 9537f8d into cargo-lambda:main Mar 12, 2025
6 checks passed
@github-actions
Copy link
Contributor

This pull request has been automatically locked. Create a new discussion if you'd like to continue the conversation. https://github.com/cargo-lambda/cargo-lambda/discussions/new?category=general

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants