Fix conflicting short options#858
Merged
calavera merged 2 commits intocargo-lambda:mainfrom May 15, 2025
Merged
Conversation
Contributor
|
Was this intended to be merged @calavera ? |
Collaborator
|
oh, yeah, sorry about that. Merging! |
Contributor
|
This pull request has been automatically locked. Create a new discussion if you'd like to continue the conversation. https://github.com/cargo-lambda/cargo-lambda/discussions/new?category=general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a couple of the short options for the
invokesubcommand are in conflict.Just to be sure, I went through all the subcommand short options to see if there were any others:
builddeploywatchinitinvokenewsystem-aaliasinvoke-addressinvoke-address/alias-ccompiler-hhelphelphelphelphelphelphelp-iincludeinclude-jjobsjobs-llambda-dirlambda-dir-mmanifest-path-ooutput-formatoutput-formatopenoutput-formatopenoutput-format-ppackageprofilepackageinvoke-port/profilepackage-qquietquiet-rreleaseregionreleaseregion-vverboseverboseverboseverboseverboseverboseverbose-wwait-xcontextcontextcontextcontextcontextcontextcontext-yno-interactiveno-interactive-Adata-ascii-Edata-example-Ffeaturesfeaturesdata-file-Pinvoke-port-Rremote-ZflagflagAs you can see, it's just
-aand-poninvokethat are a problem.I updated:
--invoke-portoninvoketo use-P(so that it matches with e.g. thewatchsubcommand); and--invoke-addressoninvoketo use-A(to match-P); and--invoke-addressonwatchto use-A(to match the two above).Fixes #857.