fix(deploy): allow to set iam role tags when created#869
Merged
calavera merged 2 commits intocargo-lambda:mainfrom Jul 15, 2025
Merged
fix(deploy): allow to set iam role tags when created#869calavera merged 2 commits intocargo-lambda:mainfrom
calavera merged 2 commits intocargo-lambda:mainfrom
Conversation
calavera
approved these changes
Jul 15, 2025
Collaborator
calavera
left a comment
There was a problem hiding this comment.
Nice, thanks a lot for the contribution!
Contributor
Author
|
I see clippy produces many changes unrelated to the PR changes, shoudl I go ahead commiting them? |
Collaborator
I'm about to push a PR with all those clippy changes. I think after they're in main, this PR should pass cleanly with a merge. |
Collaborator
|
I'll release a new version with this feature this week. |
Contributor
Author
|
thanks, @calavera |
Contributor
|
This pull request has been automatically locked. Create a new discussion if you'd like to continue the conversation. https://github.com/cargo-lambda/cargo-lambda/discussions/new?category=general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to have better overview in the AWS Resource Explorer what resources was created by the cargo-lambda, I'm adding tags for the iam role created during deploy
here is how it works: