Fixes #888: ClasspathElementZip.getClasspathElementURI() returns inco…#889
Merged
lukehutch merged 1 commit intoclassgraph:latestfrom Nov 12, 2024
Merged
Fixes #888: ClasspathElementZip.getClasspathElementURI() returns inco…#889lukehutch merged 1 commit intoclassgraph:latestfrom
lukehutch merged 1 commit intoclassgraph:latestfrom
Conversation
…turns incorrect URIs under Windows. * Use file:/// for absolute paths and file: for relative paths. * Added "Test" suffix to unit tests that were being skipped by Surefire.
Contributor
Author
|
Any idea why the build is failing on MacOS? |
Member
|
I created a bug to track the macOS build failure, #890. It's probably a failure to find the Mac version of the Narcissus library (this is not related to your changes, it started happening recently, and I haven't had a chance to look into it yet). The single windows failure is an example of #810, which again you can ignore (it is going to be tricky to track that one down, since it involves a race condition somewhere, which should be impossible given how ClassGraph was built, but apparently is not...). |
Member
|
Sorry to drop the ball, I thought I merged this already! |
Contributor
Author
|
No worries, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rrect URIs under Windows.