-
Notifications
You must be signed in to change notification settings - Fork 8k
Closed
Labels
enhancementa request to improve CLIa request to improve CLIneeds-investigationCLI team needs to investigateCLI team needs to investigatewindowsRelated to Windows hosts or runnersRelated to Windows hosts or runners
Description
Describe the bug
ProductVersion and FileVersion should be set in .exe at buildtime.
This affects version management and ability to find any vulnerable versions
Affected versions
Probably all, but verified with these gh --version
gh version 2.63.1 (2024-12-03)
https://github.com/cli/cli/releases/tag/v2.63.1
gh version 2.67.0 (2025-02-11)
https://github.com/cli/cli/releases/tag/v2.67.0
gh version 2.68.1 (2025-03-06)
https://github.com/cli/cli/releases/tag/v2.68.1
Steps to reproduce the behavior
Check details from explorer, or this in powershell:
[System.Diagnostics.FileVersionInfo]::GetVersionInfo("C:\Program Files\GitHub CLI\gh.exe")Expected vs actual behavior
ProductVersion FileVersion FileName
-------------- ----------- --------
2.68.1 (2025-03-26) 2.68.1 C:\Program Files\GitHub CLI\gh.exe
Actual:
ProductVersion FileVersion FileName
-------------- ----------- --------
C:\Program Files\GitHub CLI\gh.exe
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementa request to improve CLIa request to improve CLIneeds-investigationCLI team needs to investigateCLI team needs to investigatewindowsRelated to Windows hosts or runnersRelated to Windows hosts or runners
