-
Notifications
You must be signed in to change notification settings - Fork 8k
Closed
Description
Overview
Both the Lint and Unit and Integration Tests workflows run on push and pull_request events. Unfortunately, these workflows run 2 sets of jobs on pull requests because the push event trigger is not restricted to trunk branch.
For example, the checks from #11306 demonstrates 7 redundant checks including build, integration-tests, and lint are performed:
Reasons for not having redundant GitHub Actions workflow runs on PRs:
- reduce wasted compute resources
- remove potential problems caused by errors from redundant jobs
- improve clarity of PR status
- improve user experience of PR reviews
During discussion with maintainers, other maintainers agreed it was still valuable for these workflows to run when push to trunk branch happen especially for changes made outside of PRs.
Expected outcome
- Aforementioned workflows only run once during pull requests
- Aforementioned workflows run on pushes to
trunkbranch
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels