Bump golangci-lint to v2 by williammartin · Pull Request #11121 · cli/cli

williammartin · 2025-06-16T15:51:18Z

Description

williammartin · 2025-06-16T15:52:00Z

.github/workflows/lint.yml

-          assert-nothing-changed go fmt ./...
          assert-nothing-changed go mod tidy
-
-          bin/golangci-lint run --out-format=colored-line-number --timeout=3m || STATUS=$?


colored-line-number has been enabled by default.

--out-format seems to have been removed.

williammartin · 2025-06-16T15:52:28Z

.github/workflows/lint.yml

            fi
          }
-
-          assert-nothing-changed go fmt ./...


This is handled directly by golangci-lint now with

formatters: enable: - gofmt

Copilot

Pull Request Overview

This PR upgrades the project’s golangci-lint setup to v2 and simplifies the CI workflow accordingly.

Bump .golangci.yml to v2 and adjust which linters are enabled/disabled.
Replace manual golangci-lint install steps in CI with the official golangci-lint-action@v2.1.6.
Rename and streamline the dependency and formatting checks in the lint workflow.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
.golangci.yml	Updated `version` to `"2"`, added `disable` block under `linters`.
.github/workflows/lint.yml	Removed manual CLI download, added official golangci-lint action, renamed steps.

Comments suppressed due to low confidence (3)

.github/workflows/lint.yml:42

Consider re-adding the assert-nothing-changed go fmt ./... check to ensure code formatting issues are caught in CI.

assert-nothing-changed go mod tidy

.github/workflows/lint.yml:30

Consider adding a go mod verify step before go mod tidy to ensure module integrity is validated during the check.

- name: Ensure go.mod and go.sum are up to date

.golangci.yml:7

[nitpick] It may help maintainability to reference a tracking issue or TODO for when you plan to re-enable these linters in the future.

# The following linters are disabled purely because this config was migrated to v2 where they are in the default

.github/workflows/lint.yml

andyfeller · 2025-06-16T20:11:50Z

.github/workflows/lint.yml

+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9
+        with:
+          version: v2.1.6


thought: I don't know if we need any of the following just yet, but some other inputs I've seen added here might be pertinent based on experience:

# this fixes a bug where sometimes the pkg cache gets corrupted skip-cache: true # this is 'binary' by default install-mode: goinstall

From what I read binary was faster, why would we want goinstall? Do you have any more info on the cache issue? I guess I'd rather default to any caching we can to keep things faster.

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>

babakks

LGTM! 🙏 Locally tested the config, and all is okay.

babakks · 2025-06-17T09:20:20Z

.golangci.yml

+   # The following linters are disabled purely because this config was migrated to v2 where they are in the default
+   # set, and we should have separate work to enable them if we truly want them.


Thanks for clarification. 🙏

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | patch | `v2.74.1` -> `v2.74.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.74.2`](https://github.com/cli/cli/releases/tag/v2.74.2): GitHub CLI 2.74.2 [Compare Source](cli/cli@v2.74.1...v2.74.2) #### What's Changed ##### 🐛 Fixes - Fix assignees being dropped from `gh pr edit` by [@BagToad](https://github.com/BagToad) in cli/cli#11065 - Add accurate context when run rerun fails by [@leudz](https://github.com/leudz) in cli/cli#10774 - Avoid requesting MR reviewer twice by [@williammartin](https://github.com/williammartin) in cli/cli#11099 - Quote filenames suggested at the end of worklow run by [@williammartin](https://github.com/williammartin) in cli/cli#11134 - Fix expected error output of TestRepo/repo-rename-transfer-ownership by [@aconsuegra](https://github.com/aconsuegra) in cli/cli#10888 ##### 📚 Docs & Chores - Add instructions for MidnightBSD installation by [@laffer1](https://github.com/laffer1) in cli/cli#10699 - docs: update install command for Debian by [@MagneticNeedle](https://github.com/MagneticNeedle) in cli/cli#10935 - Fix step order for CodeQL workflow by [@BagToad](https://github.com/BagToad) in cli/cli#11145 - Add workflow to check `help wanted` labelling by [@williammartin](https://github.com/williammartin) in cli/cli#11105 - Quote workflow conditional by [@williammartin](https://github.com/williammartin) in cli/cli#11122 - Fix script path for help-wanted check by [@BagToad](https://github.com/BagToad) in cli/cli#11125 - Exclude 3rd party license compliance content from GHAS scanning by [@andyfeller](https://github.com/andyfeller) in cli/cli#11127 - Second fix for file not found in help-wanted check by [@BagToad](https://github.com/BagToad) in cli/cli#11128 - Ensure gh executes in workflow check script by [@williammartin](https://github.com/williammartin) in cli/cli#11133 - Improve help wanted check skipping logic by [@BagToad](https://github.com/BagToad) in cli/cli#11135 #####

Dependencies - Bump go to 1.24 by [@williammartin](https://github.com/williammartin) in cli/cli#11142 - chore(deps): bump mislav/bump-homebrew-formula-action from 3.2 to 3.4 by [@dependabot](https://github.com/dependabot) in cli/cli#11066 - chore(deps): bump github.com/sigstore/protobuf-specs from 0.4.2 to 0.4.3 by [@dependabot](https://github.com/dependabot) in cli/cli#11092 - chore(deps): bump google.golang.org/grpc from 1.72.0 to 1.72.2 by [@dependabot](https://github.com/dependabot) in cli/cli#11033 - chore(deps): bump actions/attest-build-provenance from 2.3.0 to 2.4.0 by [@dependabot](https://github.com/dependabot) in cli/cli#11107 - chore(deps): bump github.com/in-toto/attestation from 1.1.1 to 1.1.2 by [@dependabot](https://github.com/dependabot) in cli/cli#11123 - chore(deps): bump github.com/google/go-containerregistry from 0.20.3 to 0.20.6 by [@dependabot](https://github.com/dependabot) in cli/cli#11120 - Bump golangci-lint to v2 by [@williammartin](https://github.com/williammartin) in cli/cli#11121 #### New Contributors - [@MagneticNeedle](https://github.com/MagneticNeedle) made their first contribution in cli/cli#10935 - [@laffer1](https://github.com/laffer1) made their first contribution in cli/cli#10699 **Full Changelog**: cli/cli@v2.74.1...v2.74.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Bump golangci-lint to v2

d3f8ae9

Copilot AI review requested due to automatic review settings June 16, 2025 15:51

williammartin requested a review from a team as a code owner June 16, 2025 15:51

williammartin linked an issue Jun 16, 2025 that may be closed by this pull request

Use golangci-lint version 2 #11101

Closed

williammartin requested a review from andyfeller June 16, 2025 15:51

williammartin temporarily deployed to cli-automation June 16, 2025 15:51 — with GitHub Actions Inactive

cliAutomation assigned williammartin Jun 16, 2025

williammartin commented Jun 16, 2025

View reviewed changes

Copilot AI reviewed Jun 16, 2025

View reviewed changes

BagToad reviewed Jun 16, 2025

View reviewed changes

.github/workflows/lint.yml Outdated Show resolved Hide resolved

andyfeller reviewed Jun 16, 2025

View reviewed changes

Update .github/workflows/lint.yml

ce8b9d5

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>

williammartin mentioned this pull request Jun 17, 2025

Bump go to 1.24 #11142

Merged

babakks approved these changes Jun 17, 2025

View reviewed changes

williammartin merged commit 86c2511 into trunk Jun 17, 2025
15 checks passed

williammartin deleted the 11101-use-golangci-lint-version-2 branch June 17, 2025 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump golangci-lint to v2#11121

Bump golangci-lint to v2#11121
williammartin merged 2 commits intotrunkfrom
11101-use-golangci-lint-version-2

williammartin commented Jun 16, 2025

Uh oh!

williammartin Jun 16, 2025

Uh oh!

williammartin Jun 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

andyfeller Jun 16, 2025

Uh oh!

williammartin Jun 17, 2025 •

edited

Loading

Uh oh!

babakks left a comment

Uh oh!

babakks Jun 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

		# The following linters are disabled purely because this config was migrated to v2 where they are in the default
		# set, and we should have separate work to enable them if we truly want them.

Conversation

williammartin commented Jun 16, 2025

Description

Uh oh!

williammartin Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

williammartin Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

andyfeller Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

williammartin Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

babakks left a comment

Choose a reason for hiding this comment

Uh oh!

babakks Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

williammartin Jun 17, 2025 •

edited

Loading