Bump google.golang.org/grpc & other required dependencies by BagToad · Pull Request #11510 · cli/cli

BagToad · 2025-08-14T16:19:01Z

Supersedes chore(deps): bump google.golang.org/grpc from 1.73.0 to 1.74.2 #11367
Supersedes chore(deps): bump golang.org/x/term from 0.33.0 to 0.34.0 #11476
Supersedes chore(deps): bump google.golang.org/protobuf from 1.36.6 to 1.36.7 #11472

#11367 attempts to bump google.golang.org/grpc but just bumping this causes our build to fail because our indirect dependency github.com/GoogleCloudPlatform/grpc-gcp-go/grpcgcp has an incomplete interface definition that was added in the new google.golang.org/grpc.

# github.com/GoogleCloudPlatform/grpc-gcp-go/grpcgcp
../../../../go/pkg/mod/github.com/!google!cloud!platform/grpc-gcp-go/grpcgcp@v1.5.2/gcp_balancer.go:40:27: cannot use (*gcpBalancer)(nil) (value of type *gcpBalancer) as balancer.Balancer value in variable declaration: *gcpBalancer does not implement balancer.Balancer (missing method ExitIdle)
../../../../go/pkg/mod/github.com/!google!cloud!platform/grpc-gcp-go/grpcgcp@v1.5.2/gcp_balancer.go:86:9: cannot use gb (variable of type *gcpBalancer) as balancer.Balancer value in return statement: *gcpBalancer does not implement balancer.Balancer (missing method ExitIdle)
exit status 1
build.go: building task `bin/gh` failed.
make: *** [bin/gh] Error 1

The new version v1.5.3 of github.com/GoogleCloudPlatform/grpc-gcp-go/grpcgcp however implements the missing interface and makes our build and tests pass.

However, bumping github.com/GoogleCloudPlatform/grpc-gcp-go/grpcgcp also bumps a handful of other direct dependencies, including:

golang.org/x/crypto -> v0.41.0
golang.org/x/term -> v0.34.0
golang.org/x/text -> v0.28.0
google.golang.org/protobuf -> v1.36.7

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.73.0 to 1.74.2. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.73.0...v1.74.2) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.74.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bump several dependencies in go.mod and go.sum, including golang.org/x/crypto, golang.org/x/net, golang.org/x/sys, golang.org/x/term, golang.org/x/text, golang.org/x/tools, google.golang.org/protobuf, google.golang.org/genproto/googleapis/rpc, and github.com/GoogleCloudPlatform/grpc-gcp-go/grpcgcp. This keeps the project up to date with the latest bug fixes and improvements.

Copilot

Pull Request Overview

This PR updates gRPC and related dependencies to newer versions, primarily upgrading google.golang.org/grpc from v1.73.0 to v1.74.2 along with associated dependencies.

Bumps google.golang.org/grpc from v1.73.0 to v1.74.2
Updates golang.org/x dependencies (crypto, term, text, net, sys, tools)
Updates Google Cloud and protobuf related dependencies

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

andyfeller · 2025-08-14T17:38:15Z

@cli/package-security : with this dependency primarily being used by gh attestations, I'd appreciate a review from someone for concerns.

andyfeller

just basing this on existing tests, these updates look good.

i still wonder if we should do weekly bulk dependency updates for situations like this. will bring it up again when this happens.

cc'd our friends around gh attestation but i feel comfortable approving

malancas

Looks good to me on behalf of @cli/package-security

babakks

LGTM! Thanks for the pairing and review. 🙏

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.76.2` -> `v2.78.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.78.0`](https://github.com/cli/cli/releases/tag/v2.78.0): GitHub CLI 2.78.0 [Compare Source](cli/cli@v2.77.0...v2.78.0) #### ℹ️ Note This release was cut primarily to resolve a Linux package distribution issue. We recommend reviewing [the v2.77.0 release notes](https://github.com/cli/cli/releases/tag/v2.77.0) for the complete set of latest features and fixes. #### What's Changed ##### ✨ Features - Add `--force` flag to `gh run cancel` by [@ankddev](https://github.com/ankddev) in [#11513](cli/cli#11513) ##### 🐛 Fixes - Fix failing to release Linux packages (affected v2.77.0). See [v2.77.0](https://github.com/cli/cli/releases/tag/v2.77.0) for more information. **Full Changelog**: <cli/cli@v2.77.0...v2.78.0> ### [`v2.77.0`](https://github.com/cli/cli/releases/tag/v2.77.0): GitHub CLI 2.77.0 [Compare Source](cli/cli@v2.76.2...v2.77.0) #### ⚠️ Incomplete Release The v2.77.0 release experienced a failure publishing to our official Linux repos. This is resolved in [v2.78.0](https://github.com/cli/cli/releases/tag/v2.78.0), so we recommend using that release instead. #### What's Changed ##### ✨ Features - Report that v1 classic projects are detected on GHES 3.16.x or older by [@andyfeller](https://github.com/andyfeller) in [#11491](cli/cli#11491) - Display v2 projects in `gh issue view` by [@andyfeller](https://github.com/andyfeller) in [#11496](cli/cli#11496) - View v2 projects in `gh pr view` output by [@andyfeller](https://github.com/andyfeller) in [#11497](cli/cli#11497) - Ensure users can see v2 projects when viewing issues and MRs, avoid v1 projects on GHES 3.17 and newer by [@andyfeller](https://github.com/andyfeller) in [#11514](cli/cli#11514) ##### 🐛 Fixes - fix error for ErrReleaseNotFound when fetching ref by [@ejahnGithub](https://github.com/ejahnGithub) in [#11451](cli/cli#11451) - add test for FetchRefSHA by [@ejahnGithub](https://github.com/ejahnGithub) in [#11481](cli/cli#11481) - Fix `gh repo delete --yes` safety issue when no repository argument provided by [@Copilot](https://github.com/Copilot) in [#11536](cli/cli#11536) ##### 📚 Docs & Chores - Improve spam detection evals by [@babakks](https://github.com/babakks) in [#11419](cli/cli#11419) - Fix `help wanted` label regexp in CI automation by [@babakks](https://github.com/babakks) in [#11423](cli/cli#11423) - Update spam detection to comment on and close issue by [@andyfeller](https://github.com/andyfeller) in [#11435](cli/cli#11435) - Adding a note to `gh search` docs to explain the usage of `--` to exclude certain results by [@Sukhpreet-s](https://github.com/Sukhpreet-s) in [#11162](cli/cli#11162) - Update issue triage guidelines and label usage by [@BagToad](https://github.com/BagToad) in [#11454](cli/cli#11454) - Reorganize installation docs by [@andyfeller](https://github.com/andyfeller) in [#11473](cli/cli#11473) - Update govulncheck workflow to scan source code by [@BagToad](https://github.com/BagToad) in [#11482](cli/cli#11482) - Hidden trusted root flag for release verify by [@ejahnGithub](https://github.com/ejahnGithub) in [#11511](cli/cli#11511) #####

Dependencies - Regenerate third-party licenses on trunk pushes by [@andyfeller](https://github.com/andyfeller) in [#11370](cli/cli#11370) - Update third-party license versions by [@BagToad](https://github.com/BagToad) in [#11557](cli/cli#11557) - Bump Go to 1.24.6 by [@github-actions](https://github.com/github-actions)\[bot] in [#11467](cli/cli#11467) - chore(deps): bump github.com/spf13/pflag from 1.0.6 to 1.0.7 by [@dependabot](https://github.com/dependabot)\[bot] in [#11319](cli/cli#11319) - chore(deps): bump actions/download-artifact from 4 to 5 by [@dependabot](https://github.com/dependabot)\[bot] in [#11458](cli/cli#11458) - chore(deps): bump actions/checkout from 4 to 5 by [@dependabot](https://github.com/dependabot)\[bot] in [#11490](cli/cli#11490) - chore(deps): bump github.com/yuin/goldmark from 1.7.12 to 1.7.13 by [@dependabot](https://github.com/dependabot)\[bot] in [#11368](cli/cli#11368) - Bump google.golang.org/grpc & other required dependencies by [@BagToad](https://github.com/BagToad) in [#11510](cli/cli#11510) - chore(deps): bump google.golang.org/grpc from 1.73.0 to 1.74.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#11367](cli/cli#11367) - chore(deps): bump github.com/cli/go-gh/v2 from 2.12.1 to 2.12.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#11537](cli/cli#11537) - chore(deps): bump github.com/go-viper/mapstructure/v2 from 2.3.0 to 2.4.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#11556](cli/cli#11556) #### New Contributors - [@Sukhpreet-s](https://github.com/Sukhpreet-s) made their first contribution in [#11162](cli/cli#11162) - [@Copilot](https://github.com/Copilot) made their first contribution in [#11536](cli/cli#11536) **Full Changelog**: <cli/cli@v2.76.2...v2.77.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

dependabot bot and others added 2 commits August 8, 2025 13:40

Copilot AI review requested due to automatic review settings August 14, 2025 16:19

BagToad requested a review from a team as a code owner August 14, 2025 16:19

BagToad requested a review from andyfeller August 14, 2025 16:19

BagToad temporarily deployed to cli-automation August 14, 2025 16:19 — with GitHub Actions Inactive

cliAutomation assigned BagToad Aug 14, 2025

Copilot AI reviewed Aug 14, 2025

View reviewed changes

andyfeller approved these changes Aug 14, 2025

View reviewed changes

malancas approved these changes Aug 14, 2025

View reviewed changes

BagToad requested a review from babakks August 14, 2025 20:33

babakks approved these changes Aug 15, 2025

View reviewed changes

BagToad merged commit f648924 into trunk Aug 15, 2025
12 of 13 checks passed

BagToad deleted the kw/upgrade-grpc-batch branch August 15, 2025 15:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump google.golang.org/grpc & other required dependencies#11510

Bump google.golang.org/grpc & other required dependencies#11510
BagToad merged 2 commits intotrunkfrom
kw/upgrade-grpc-batch

BagToad commented Aug 14, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

andyfeller commented Aug 14, 2025

Uh oh!

andyfeller left a comment

Uh oh!

malancas left a comment

Uh oh!

babakks left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

BagToad commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

andyfeller commented Aug 14, 2025

Uh oh!

andyfeller left a comment

Choose a reason for hiding this comment

Uh oh!

malancas left a comment

Choose a reason for hiding this comment

Uh oh!

babakks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

BagToad commented Aug 14, 2025 •

edited

Loading