Conversation
Previously, deleting caches by key or key+ref could misreport the number of deleted entries, especially when multiple caches matched the criteria. This change ensures the actual number of deleted caches is reported by consuming the API response's total_count field.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes incorrect cache deletion count reporting when deleting caches by key or key+ref, ensuring the actual number of deleted caches is displayed by consuming the API response's total_count field.
- Replaced hardcoded deletion count with API response's total_count field
- Split cache deletion logic into separate functions for ID and key-based deletions
- Added comprehensive test coverage for multiple cache deletions scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/cmd/cache/delete/delete.go | Refactored deletion logic to track actual deleted count and separated API calls by deletion type |
| pkg/cmd/cache/delete/delete_test.go | Added test cases for multiple cache deletions and updated existing tests to use proper JSON responses |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Oct 17, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.81.0` -> `v2.82.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.82.0`](https://github.com/cli/cli/releases/tag/v2.82.0): GitHub CLI 2.82.0 [Compare Source](cli/cli@v2.81.0...v2.82.0) ##### ✨ Features - `gh pr edit`: Only fetch org teams for reviewers when required by [@​BagToad](https://github.com/BagToad) in [#​11835](cli/cli#11835) ##### 🐛 Fixes - fix(cache delete): report correct deleted count for key and key+ref deletions by [@​luxass](https://github.com/luxass) in [#​11838](cli/cli#11838) - `gh agent-task create`: Fix `--follow` not killing the progress indicator by [@​BagToad](https://github.com/BagToad) in [#​11879](cli/cli#11879) - `gh agent-task create`: Fix targetting upstream instead of default repo by [@​BagToad](https://github.com/BagToad) in [#​11896](cli/cli#11896) - Fix `auth login` and `auth refresh` to use UNIX socket by [@​babakks](https://github.com/babakks) in [#​11922](cli/cli#11922) **Full Changelog**: <cli/cli@v2.81.0...v2.82.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDguNiIsInVwZGF0ZWRJblZlciI6IjQxLjE0OC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, deleting caches by key or key+ref could misreport the number of deleted entries, especially when multiple caches matched the criteria. This change ensures the actual number of deleted caches is reported by consuming the API response's total_count field.
resolves #11595