💡 (gh repo delete) Add warning when `--yes` is ignored without a repository, Closes: #12033 by Shion1305 · Pull Request #12039 · cli/cli

Shion1305 · 2025-10-28T18:31:55Z

Fixes #12033

Description

When gh repo delete --yes is used without an explicit OWNER/REPO, the flag is ignored (for safety).
Users may miss this and assume non-interactive deletion. This PR surfaces a clear notice in interactive mode and preserves an error in non-interactive mode, making the behavior explicit and script-friendly.

Changes

In interactive (TTY) runs with --yes but no OWNER/REPO, print:

Warning: `--yes` is ignored since no repository was specified

Expected behavior

gh repo delete --yes (TTY) → emits warning; proceeds interactively.
gh repo delete --yes (non-TTY) → returns the existing error; no warning.
gh repo delete OWNER/REPO --yes → unchanged (non-interactive deletion).

Notes

To verify that the warning is printed to stderr only in interactive environments, I added assertions for both wantStderr and wantErrMsg.
While this may look slightly redundant, the logic for printing errors and warnings to stderr is handled internally by Cobra.

Acceptance Criteria

Given I'm running gh interactively from a cloned repo directory When I run gh repo delete --yes Then I see the below warning message on stderr and then the prompt to confirm the repo name:
Warning: `--yes` is ignored since no repository was specified

#12033 (comment)

…sitory, Closes: cli#12033

pkg/cmd/repo/delete/delete_test.go

Copilot

Pull Request Overview

This PR adds a warning message when the --yes flag is used without specifying a repository argument, and enhances test coverage to verify stderr output in various scenarios.

Added warning message output when --yes is ignored (no repository argument provided in TTY mode)
Renamed test field errMsg to wantErrMsg for consistency with wantStderr
Enhanced test assertions to verify stderr output matches expected warnings and error messages

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
pkg/cmd/repo/delete/delete.go	Adds warning output to stderr when `--yes` flag is ignored due to missing repository argument
pkg/cmd/repo/delete/delete_test.go	Adds `wantStderr` field to test cases and captures stderr for validation; renames `errMsg` to `wantErrMsg`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

BagToad

LGTM! Thanks for the idea and contribution @Shion1305 ❤️

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.82.1` -> `v2.83.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.83.0`](https://github.com/cli/cli/releases/tag/v2.83.0): GitHub CLI 2.83.0 [Compare Source](cli/cli@v2.82.1...v2.83.0) #### What's Changed ##### ✨ Features - Add `isImmutable` to `release list` JSON output by [@babakks](https://github.com/babakks) in [#12064](cli/cli#12064) - `gh agent-task create`: support `--custom-agent`/`-a` flag by [@BagToad](https://github.com/BagToad) in [#12068](cli/cli#12068) - 💡 (gh repo delete) Add warning when `--yes` is ignored without a repository, Closes: [#12033](cli/cli#12033) by [@Shion1305](https://github.com/Shion1305) in [#12039](cli/cli#12039) - feat: implement gh `pr revert` by [@lucasmelin](https://github.com/lucasmelin) in [#8826](cli/cli#8826) ##### 🐛 Fixes - fix(gist): add support for editing & viewing large files by [@luxass](https://github.com/luxass) in [#11761](cli/cli#11761) - Fix gh attestation verify to work when Public Good Instance of Sigstore is unavailable by [@Copilot](https://github.com/Copilot) in [#11989](cli/cli#11989) ##### 📚 Docs & Chores - chore: add basic linters by [@babakks](https://github.com/babakks) in [#12084](cli/cli#12084) - CI: Update lint govulncheck to use source mode by [@BagToad](https://github.com/BagToad) in [#12089](cli/cli#12089) - chore: add `workflow_dispatch` to govulncheck triggers by [@babakks](https://github.com/babakks) in [#12085](cli/cli#12085) - Exclude `third-party` from Golangci-lint formatting paths by [@babakks](https://github.com/babakks) in [#12058](cli/cli#12058) - Apply `go fix` to remove deprecated `// +build` tags by [@babakks](https://github.com/babakks) in [#12056](cli/cli#12056) - Bump Golangci-lint to `v2.6.0` by [@babakks](https://github.com/babakks) in [#12049](cli/cli#12049) - Mention `pr checks` in `run list` docs by [@babakks](https://github.com/babakks) in [#12050](cli/cli#12050) - Fix typo in comment for `gh issue develop` branch checkout command by [@jonzfisher](https://github.com/jonzfisher) in [#12042](cli/cli#12042) - Use "release" sentinel value for release attestation verification by [@Copilot](https://github.com/Copilot) in [#11991](cli/cli#11991) - Improve docstring for release-create by [@bdehamer](https://github.com/bdehamer) in [#11945](cli/cli#11945) - Improve `api` command docs around `--input` and `--field` by [@babakks](https://github.com/babakks) in [#12062](cli/cli#12062) - Fix `--interval` flags docs in `gh pr checks` by [@2003Aditya](https://github.com/2003Aditya) in [#12053](cli/cli#12053) #####

Dependencies - Bump Go to 1.25.3 by [@github-actions](https://github.com/github-actions)\[bot] in [#11926](cli/cli#11926) - chore(deps): bump github.com/cli/go-gh/v2 from 2.12.2 to 2.13.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#12095](cli/cli#12095) - Update Go toolchain version to 1.24.9 by [@BagToad](https://github.com/BagToad) in [#12054](cli/cli#12054) - chore(deps): bump golang.org/x/text from 0.29.0 to 0.30.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#11973](cli/cli#11973) - chore(deps): bump golang.org/x/crypto from 0.42.0 to 0.43.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#11974](cli/cli#11974) - chore(deps): bump actions/upload-artifact from 4 to 5 by [@dependabot](https://github.com/dependabot)\[bot] in [#12031](cli/cli#12031) - chore(deps): bump actions/download-artifact from 5 to 6 by [@dependabot](https://github.com/dependabot)\[bot] in [#12032](cli/cli#12032) - chore(deps): bump github.com/rivo/tview from 0.0.0-20250625164341-a4a78f1e05cb to 0.42.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#12000](cli/cli#12000) - chore(deps): bump goreleaser/goreleaser-action from 6.3.0 to 6.4.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#11509](cli/cli#11509) - chore(deps): bump mislav/bump-homebrew-formula-action from 3.4 to 3.6 by [@dependabot](https://github.com/dependabot)\[bot] in [#11750](cli/cli#11750) #### New Contributors - [@lucasmelin](https://github.com/lucasmelin) made their first contribution in [#8826](cli/cli#8826) - [@jonzfisher](https://github.com/jonzfisher) made their first contribution in [#12042](cli/cli#12042) - [@2003Aditya](https://github.com/2003Aditya) made their first contribution in [#12053](cli/cli#12053) **Full Changelog**: <cli/cli@v2.82.1...v2.83.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

💡 (gh repo delete) Add warning when --yes is ignored without a repo…

7083f6d

…sitory, Closes: cli#12033

Copilot AI review requested due to automatic review settings October 28, 2025 18:31

Shion1305 requested a review from a team as a code owner October 28, 2025 18:31

Shion1305 requested a review from BagToad October 28, 2025 18:31

Shion1305 temporarily deployed to cli-automation October 28, 2025 18:32 — with GitHub Actions Inactive

cliAutomation added the external pull request originating outside of the CLI core team label Oct 28, 2025

Shion1305 commented Oct 28, 2025

View reviewed changes

pkg/cmd/repo/delete/delete_test.go Show resolved Hide resolved

Copilot AI reviewed Oct 28, 2025

View reviewed changes

✅ (repo delete) remove comprehensive assertions on check stderr output

a7f1457

BagToad approved these changes Oct 29, 2025

View reviewed changes

BagToad merged commit 119085c into cli:trunk Oct 29, 2025
11 checks passed

Shion1305 deleted the shion/feat-12033 branch October 29, 2025 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

💡 (gh repo delete) Add warning when `--yes` is ignored without a repository, Closes: #12033#12039

💡 (gh repo delete) Add warning when `--yes` is ignored without a repository, Closes: #12033#12039
BagToad merged 2 commits intocli:trunkfrom
Shion1305:shion/feat-12033

Shion1305 commented Oct 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

BagToad left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Shion1305 commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Expected behavior

Notes

Acceptance Criteria

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

BagToad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Shion1305 commented Oct 28, 2025 •

edited

Loading