Fix pr create when branch was already pushed to a non-base remote#1926
Merged
Fix pr create when branch was already pushed to a non-base remote#1926
pr create when branch was already pushed to a non-base remote#1926Conversation
Our previous command stub mechanism matches stubs sequentially, which leads to brittle tests when the exec calls get reordered or removed in the implementation.
samcoe
approved these changes
Sep 24, 2020
Contributor
samcoe
left a comment
There was a problem hiding this comment.
I like the new stub approach. Seems more flexible and robust than the previous version.
This was referenced Oct 9, 2020
|
This PR says it fixes #2001, though I believe I'm still seeing that behaviour in the 1.3.0 release from a few days ago (as are others). If I run |
|
Oh, FWIW - seems like this only affects |
Contributor
Author
|
@DanTup Thanks for the report! We're fixing this already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bonus: also proposes a new command stubber for tests, one that matches commands by their invocation instead of sequentially and also asserts that all stubs have matched at the end of the test.
Fixes #1820, fixes #1762, fixes #1869, fixes #2001