Make: Fix target name for Windows platform#7370
Merged
mislav merged 1 commit intocli:deploymentfrom Apr 25, 2023
Biswa96:fix-makefile
Merged
Make: Fix target name for Windows platform#7370mislav merged 1 commit intocli:deploymentfrom Biswa96:fix-makefile
mislav merged 1 commit intocli:deploymentfrom
Biswa96:fix-makefile
Conversation
Contributor
Biswa96
commented
Apr 25, 2023
This fixes the taget name by adding .exe extension for Windows platform. Otherwise, the following error is shown with `make bin/gh.exe' command. make: *** No rule to make target 'script/build', needed by 'bin/gh.exe'. Stop.
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
mislav
pushed a commit
that referenced
this pull request
May 9, 2023
This fixes the taget name by adding .exe extension for Windows platform.
Otherwise, the following error is shown with `make bin/gh.exe' command.
make: *** No rule to make target 'script/build', needed by 'bin/gh.exe'. Stop.
jtpetty
pushed a commit
that referenced
this pull request
May 22, 2023
This fixes the taget name by adding .exe extension for Windows platform.
Otherwise, the following error is shown with `make bin/gh.exe' command.
make: *** No rule to make target 'script/build', needed by 'bin/gh.exe'. Stop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.