Merged
Conversation
|
|
Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
4693833 to
022e078
Compare
Samze
approved these changes
Sep 16, 2025
marckhouzam
added a commit
to marckhouzam/cf-cli
that referenced
this pull request
Oct 27, 2025
Signed-off-by: Marc Khouzam <marc.khouzam@broadcom.com>
gururajsh
pushed a commit
that referenced
this pull request
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
I noticed this typo in the json tag. Searching the code with my IDE, I don't see any use of the field
OAuthClientexcept in a test. Furthermore, I believe this field (and its parents) are not marshalled but only unmarshalled. I am not 100% sure however. But if that is the case, it is safe to make this change since it won't break anything.Note also that from limited testing, I can see that when requesting the links from a fondation, the
app_sshlink section is served usingoauth_clientas shown belowThis means that without this PR, if the field
OAuthClientwere to be used in the future, it would not work, as it would never be filled when unmarshaling.Why Is This PR Valuable?
This PR is just about avoiding someone wasting time in the future trying to make this field work and hitting this bug.
Applicable Issues
N/A
How Urgent Is The Change?
Not urgent.
Other Relevant Parties
No one, yet.