Merged
Conversation
larkee
reviewed
May 21, 2021
…n-spanner-sqlalchemy into opentelemetry_tracing
larkee
reviewed
May 25, 2021
larkee
reviewed
May 25, 2021
| "db.params": parameters, | ||
| "db.instance": cursor.connection.database.name, | ||
| } | ||
| with trace_call("SpannerSqlAlchemy.Executemany", trace_attributes): |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| with trace_call("SpannerSqlAlchemy.Executemany", trace_attributes): | |
| with trace_call("SpannerSqlAlchemy.ExecuteMany", trace_attributes): |
larkee
approved these changes
May 25, 2021
Contributor
larkee
left a comment
There was a problem hiding this comment.
LGTM with the suggestion.
I would like some unit tests for this but they can come later. Please create an issue to track this.
Contributor
Author
|
Issue for tracking : #76 |
…n-spanner-sqlalchemy into opentelemetry_tracing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.