Provides a CachingOuptutStream and a CachingWriter#184
Merged
cstamas merged 8 commits intocodehaus-plexus:masterfrom Apr 26, 2022
Merged
Provides a CachingOuptutStream and a CachingWriter#184cstamas merged 8 commits intocodehaus-plexus:masterfrom
cstamas merged 8 commits intocodehaus-plexus:masterfrom
Conversation
olamy
approved these changes
Feb 22, 2022
olamy
reviewed
Feb 22, 2022
src/main/java/org/codehaus/plexus/util/io/CachingOutputStream.java
Outdated
Show resolved
Hide resolved
olamy
reviewed
Feb 22, 2022
cstamas
approved these changes
Apr 25, 2022
Member
Author
|
@olamy @michael-o @cstamas could one of you squash/merge this PR ? I don't have any karma to do it. |
Member
Interactive rebase does not work for you in the terminal? |
Member
Author
I suppose it does, however, I can't push to the |
Member
|
@gnodet seems merged code UT failed? |
Member
Author
|
Weird, that's the one I fixed with 0c03b46 |
Member
Author
|
So the test is flaky under linux. I'll provide a PR to make it more robust or fix the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could be used instead of codehaus-plexus/modello#116 , codehaus-plexus/plexus-containers#46 and apache/maven-plugin-tools#67